Skip to content

migrate strimzi duck types and client bindings from v1beta2 to v1#6604

Merged
squakez merged 3 commits intoapache:mainfrom
anandyadav3559:fix/kafka-setup
May 5, 2026
Merged

migrate strimzi duck types and client bindings from v1beta2 to v1#6604
squakez merged 3 commits intoapache:mainfrom
anandyadav3559:fix/kafka-setup

Conversation

@anandyadav3559
Copy link
Copy Markdown
Contributor

Issue : #6596
Renamed pkg/apis/duck/strimzi/v1beta2 package to v1.
Updated schema registration and binding resolution (KafkaV1beta2 to KafkaV1).
Regenerated Kubernetes clientsets, informers, and deepcopy functions.
Testing Unit tests in pkg/util/bindings successfully pass using the updated KafkaV1 mocks: go test -v ./pkg/util/bindings -run Strimzi

… Kafka resources

Kafka setup fails with errors like 'no matches for kind KafkaNodePool'
because Strimzi CRDs are not fully established when Kafka resources are applied.

Added explicit waits for CRDs and operator readiness to prevent race condition.

Also updated KEDA installation to use server-side apply to avoid annotation size issues.
…a2 to v1

Strimzi v1beta2 APIs are no longer supported and have been replaced by v1.
This commit migrates the Camel-K strimzi duck types from `v1beta2` to `v1`.

- Renames duck types package and references from `v1beta2` to `v1`
- Updates schema registration to point to the `v1` API group
- Regenerates Kubernetes clientset and deepcopy functions for `strimzi/v1`
- Refactors `pkg/util/bindings` provider to utilize the new `KafkaV1` client
Copy link
Copy Markdown
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

This was linked to issues May 4, 2026
@anandyadav3559
Copy link
Copy Markdown
Contributor Author

LGTM, thanks for the contribution!

Your welcome,
This is my first contribution.
I am just starting open source contribution and would love to contribute more.

@squakez
Copy link
Copy Markdown
Contributor

squakez commented May 4, 2026

We're always happy to receive contributions :)

Feel free to have a look at "good first contributions" labeled issues: https://github.com/apache/camel-k/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22good%20first%20issue%22

@squakez
Copy link
Copy Markdown
Contributor

squakez commented May 4, 2026

There's some minor lint issue:

Error: pkg/apis/addtoscheme_strimzi_duck_v1.go:21:1: File is not properly formatted (goimports)
	"github.com/apache/camel-k/v2/pkg/apis/duck/strimzi/v1"
^

you can locally run make lint-fix to automatically fix and later commit the change provided.

@anandyadav3559 anandyadav3559 deleted the fix/kafka-setup branch May 4, 2026 13:28
@anandyadav3559 anandyadav3559 restored the fix/kafka-setup branch May 4, 2026 13:28
@anandyadav3559 anandyadav3559 reopened this May 4, 2026
Comment thread e2e/kafka/setup/setup.sh

kubectl create namespace kafka
kubectl create -f 'https://strimzi.io/install/latest?namespace=kafka' -n kafka
kubectl create namespace kafka --dry-run=client -o yaml | kubectl apply -f -
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed this one. Why not creating the namespace normally as before?

@squakez squakez merged commit e8fccf2 into apache:main May 5, 2026
20 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kafka test broken Upgrade Strimzi API to v1

2 participants