Skip to content

Allow to provide custom settings.xml#717

Closed
lburgazzoli wants to merge 4 commits intoapache:masterfrom
lburgazzoli:github-715
Closed

Allow to provide custom settings.xml#717
lburgazzoli wants to merge 4 commits intoapache:masterfrom
lburgazzoli:github-715

Conversation

@lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented May 31, 2019

So now you can configure maven by providing a custom settings.xml from a configmap/secret:

apiVersion: camel.apache.org/v1alpha1
kind: IntegrationPlatform
metadata:
  labels:
    app: camel-k
  name: camel-k
spec:
  build:
    maven:
      settings:
        configMapKeyRef:
          key: s.xml
          name: maven-settings

NOTE: the possibility to set maven repositories has been removed from both platform and integration so the only option to configure maven is through the platform itself.

Fixes #715
Fixes #706

Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking :)

README.adoc Outdated
Additional maven repositories can be defined at platform installation time or at integration/context build time:
==== Configure maven settings

Maven settings can be configured by providing a custom settings.xml through a CaonfigMap or secret.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CaonfigMap -> ConfigMap

README.adoc Outdated

[source]
----
kubectl create configmap maven-settings --from-file=settigns.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

settigns.xml -> settings.xml

README.adoc Outdated
==== Configure additional maven repositories

Additional maven repositories can be defined at platform installation time or at integration/context build time:
==== Configure maven settings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maven -> Maven

README.adoc Outdated
==== Configure maven settings

Maven settings can be configured by providing a custom settings.xml through a CaonfigMap or secret.
The source for maven setttings can be configuired using either the `kamel` cli at installation time or by editing Camel K's IntegrationPlatform:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cli -> CLI

@lburgazzoli
Copy link
Contributor Author

Some nitpicking :)

oh man, how may typos was I able to make in 10 lines ?

@nicolaferraro
Copy link
Member

I love the idea of the configmap/secret to set the maven settings. But I'd prefer keeping the --repository flag because it's handy and I've used it in many installations/quickstarts and I wanted to use it for linking camel k to the staging repo when releasing.

I was thinking of keeping the --repositories as shortcut, alternative to maven settings (cannot be used together, for simplicity). Under the hood, it can even generate a simple settings.xml in a configmap if this simplifies code. Wdyt?

@lburgazzoli
Copy link
Contributor Author

We can add some short-cuts on kamel install so the xml is automatically created, could that work ?

@nicolaferraro
Copy link
Member

Yeah, that's what I meant ;)

@lburgazzoli
Copy link
Contributor Author

reworking it

@lburgazzoli lburgazzoli closed this Jun 3, 2019
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this pull request Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to provide custom settings.xml Setup the maven proxy inside of the builder

4 participants