feat: keyMatch2 implementation - #11
Merged
Merged
Conversation
|
@ngoclinhng please review |
ngoclinhng
suggested changes
Mar 18, 2022
ngoclinhng
left a comment
ngoclinhng
left a comment
Contributor
There was a problem hiding this comment.
Please add more tests for key_match_2 ( similar to this ). And also update the docs because it’s currently quite vague: what does it mean for key1 to match the pattern of key2 ? ( regex_match is straightforward since it’s a regular expression match). Btw, how about renaming key_match_2 to just key_match2? ? ( it’s a nice convention in Elixir for Boolean functions to have a question mark at the end).
Contributor
Author
Honestly I thought the documentation was enough since this is just pattern matching and pretty straight forward 🤔 |
ngoclinhng
approved these changes
Mar 18, 2022
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 12, 2025
# 1.0.0 (2025-10-12) ### Bug Fixes * add map support to request struct ([#8](#8)) ([5b0e701](5b0e701)) * add_policy at enforcer server hasn't handled a case where new_enforce comes. ([#6](#6)) ([a7478b8](a7478b8)) * enforcer_server ([#21](#21)) ([85efaa4](85efaa4)) * g3 matcher function + tests ([#13](#13)) ([d26a73c](d26a73c)) ### Features * add CI/CD automation with GitHub Actions and semantic-release ([#26](#26)) ([f775b8f](f775b8f)) * add EnforcerServer.reset_configuration/1 method ([#15](#15)) ([0e530da](0e530da)) * added persist adapters and ability to alter policies and mappings ([#19](#19)) ([d55e97a](d55e97a)) * keyMatch2 implementation ([#11](#11)) ([c68edd2](c68edd2)) * RBAC domain model ([#10](#10)) ([daafa79](daafa79)) * upgrade required elixir version to 1.13 ([#17](#17)) ([e828e3f](e828e3f)) ### BREAKING CHANGES * Drop support for elixir < 1.13 * chore: mix format * chore: Add .tool-versions
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
key_match_2/2to handlekeyMatch2matcher functionregex_match?toregexMatchto match Casbin namingkeyMatch2