fix: add map support to request struct - #8
Merged
Conversation
|
@tangyang9464 @closetool @sagilio please review |
Hawatz
force-pushed
the
add-map-support
branch
from
January 6, 2022 19:21
f38e719 to
ca9c344
Compare
Member
|
@Hawatz plz fix: |
* add is_map() check to request validation to be able to use maps in request
* update the link to point to the current repository, because the previous one is outdated
Hawatz
force-pushed
the
add-map-support
branch
from
January 7, 2022 14:25
ca9c344 to
c5285ed
Compare
Contributor
Author
|
@hsluoyz |
hsluoyz
requested review from
ngoclinhng
and removed request for
kilosonc,
sagilio and
tangyang9464
January 7, 2022 15:49
Member
|
@ngoclinhng plz review |
ngoclinhng
reviewed
Jan 9, 2022
Contributor
Author
|
We want to use Eval rule inside a policy against full obgect in request. It is available in original casbin, here is example Eval rull will have access to the user record and resources object to run ABAC model. |
ngoclinhng
approved these changes
Jan 11, 2022
Contributor
|
@hsluoyz you can merge these commits into master. |
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 12, 2025
# 1.0.0 (2025-10-12) ### Bug Fixes * add map support to request struct ([#8](#8)) ([5b0e701](5b0e701)) * add_policy at enforcer server hasn't handled a case where new_enforce comes. ([#6](#6)) ([a7478b8](a7478b8)) * enforcer_server ([#21](#21)) ([85efaa4](85efaa4)) * g3 matcher function + tests ([#13](#13)) ([d26a73c](d26a73c)) ### Features * add CI/CD automation with GitHub Actions and semantic-release ([#26](#26)) ([f775b8f](f775b8f)) * add EnforcerServer.reset_configuration/1 method ([#15](#15)) ([0e530da](0e530da)) * added persist adapters and ability to alter policies and mappings ([#19](#19)) ([d55e97a](d55e97a)) * keyMatch2 implementation ([#11](#11)) ([c68edd2](c68edd2)) * RBAC domain model ([#10](#10)) ([daafa79](daafa79)) * upgrade required elixir version to 1.13 ([#17](#17)) ([e828e3f](e828e3f)) ### BREAKING CHANGES * Drop support for elixir < 1.13 * chore: mix format * chore: Add .tool-versions
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Here we have a check for number and binary values, but what if we have a need to use maps in functions inside matcher expression
Convert maps to strings before passing it to request and back inside a function looks a bit tricky
Or maybe you have some reason to filter maps from request values?