Skip to content

fix: add tests for SetFieldIndex&GetFieldIndex - #1044

Merged
hsluoyz merged 2 commits into
apache:masterfrom
JalinWang:test-fieldindex
Jul 10, 2022
Merged

fix: add tests for SetFieldIndex&GetFieldIndex#1044
hsluoyz merged 2 commits into
apache:masterfrom
JalinWang:test-fieldindex

Conversation

@JalinWang

@JalinWang JalinWang commented Jul 1, 2022

Copy link
Copy Markdown
Contributor

@JalinWang JalinWang changed the title opt: add tests for SetFieldIndex&GetFieldIndex fix: add tests for SetFieldIndex&GetFieldIndex Jul 1, 2022
@casbin-bot

casbin-bot commented Jul 1, 2022

Copy link
Copy Markdown

@tangyang9464 @closetool @sagilio please review

@hsluoyz

hsluoyz commented Jul 1, 2022

Copy link
Copy Markdown
Member

@tangyang9464 plz review

@hsluoyz

hsluoyz commented Jul 1, 2022

Copy link
Copy Markdown
Member

@JalinWang fix:

image

@JalinWang

JalinWang commented Jul 1, 2022

Copy link
Copy Markdown
Contributor Author

@JalinWang fix:

image

done

tangyang9464
tangyang9464 approved these changes Jul 1, 2022
View reviewed changes

@tangyang9464 tangyang9464 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tangyang9464

tangyang9464 commented Jul 1, 2022

Copy link
Copy Markdown
Contributor

@JalinWang Please add the appropriate documentation for this. When users use RBAC or priority-related APIs, the default Index they should follow or how to customize FieldIndex

@JalinWang

JalinWang commented Jul 1, 2022

Copy link
Copy Markdown
Contributor Author

@JalinWang Please add the appropriate documentation for this. When users use RBAC or priority-related APIs, the default Index they should follow or how to customize FieldIndex

ok

@JalinWang

JalinWang commented Jul 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

During the document composition, I add the additional test case for the customized priority token.

image

This was referenced Jul 1, 2022
Closed
Merged
@tangyang9464

tangyang9464 commented Jul 3, 2022

Copy link
Copy Markdown
Contributor

During the document composition, I add the additional test case for the customized priority token.

image

It's ok.

@JalinWang

JalinWang commented Jul 10, 2022

Copy link
Copy Markdown
Contributor Author

@hsluoyz Is there anything more to do on this PR?

@hsluoyz
hsluoyz merged commit cfc60ff into apache:master Jul 10, 2022
@github-actions

github-actions Bot commented Jul 10, 2022

Copy link
Copy Markdown

🎉 This PR is included in version 2.50.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kilosonc kilosonc Awaiting requested review from kilosonc
@sagilio sagilio Awaiting requested review from sagilio
1 more reviewer
@tangyang9464 tangyang9464 tangyang9464 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]DeleteRole do not totally work in priority model

4 participants

@JalinWang @casbin-bot @hsluoyz @tangyang9464