Skip to content

Fix flaky SSE system tests - #3349

Merged
coheigea merged 1 commit into
mainfrom
coheigea/sse-flakes
Jul 31, 2026
Merged

Fix flaky SSE system tests#3349
coheigea merged 1 commit into
mainfrom
coheigea/sse-flakes

Conversation

@coheigea

Copy link
Copy Markdown
Contributor

The Tomcat SSE tests almost always fail on my machine, the Undertow tests sporadically. There are two changes:

  • moved the close-state check to happen after the server actually closes the connection.
  • fixed the last event counter so it only increments when an event was unexpectedly delivered, not when failure was expected after close.

@coheigea
coheigea requested a review from reta July 31, 2026 11:11

@reta reta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coheigea !

@coheigea
coheigea merged commit 7c0c411 into main Jul 31, 2026
5 checks passed
@coheigea
coheigea deleted the coheigea/sse-flakes branch July 31, 2026 13:55
coheigea added a commit that referenced this pull request Jul 31, 2026
(cherry picked from commit 7c0c411)
coheigea added a commit that referenced this pull request Jul 31, 2026
(cherry picked from commit 7c0c411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants