Skip to content

Fix flaky SSE system tests #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coheigea merged 1 commit into from
Jul 31, 2026
+8 −6
Merged

Fix flaky SSE system tests #3349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .../rs-sse-base/src/main/java/org/apache/cxf/systest/jaxrs/sse/BookStoreClientCloseable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,18 @@ public void clientCloseConnection(@Context SseEventSink sink, @PathParam("id") f
Thread.sleep(500);
localBroadcaster.broadcast(createEvent(builder.name("book"), id + 4))
.whenComplete((r, ex) -> {
// we expect the sink to be closed at this point
if (ex != null || !sink.isClosed()) {
// Count only an unexpected successful delivery after client close.
if (ex == null && !sink.isClosed()) {
stats.inc();
}
});

stats.setWasClosed(sink.isClosed());
phaser.arriveAndDeregister();

sink.close();
try {
sink.close();
} finally {
stats.setWasClosed(sink.isClosed());
phaser.arriveAndDeregister();
}
} catch (final InterruptedException ex) {
LOG.error("Communication error", ex);
} catch (final IOException ex) {
Expand Down
Loading