fix: [branch-54] send the shutdown notification before dropping the notifier (backport of #2107) - #2237
Merged
andygrove merged 1 commit intoAug 6, 2026
Conversation
(cherry picked from commit c77e481)
andygrove
marked this pull request as ready for review
August 6, 2026 12:47
phillipleblanc
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Backport of #2107 to
branch-54. The issue it fixes is #2105.Rationale for this change
The executor process hangs indefinitely on ctrl+c instead of shutting down. Shutdown is signalled by dropping
notify_shutdown, thebroadcast::Senderthat every component subscribes to, but cloned instances of that sender are still outstanding at that point, so dropping the one held bystart_executor_processdoes not close the channel and the subscribers never observe the shutdown.What changes are included in this PR?
A clean cherry-pick of c77e481, unmodified.
Sends an explicit
notify_shutdown.send(())before the drop, so subscribers receive the signal regardless of how many senders are still alive. One line inballista/executor/src/executor_process.rs.Are there any user-facing changes?
The executor now exits on ctrl+c instead of hanging. No API, config, or wire format changes.
Verified locally on the
branch-54base:cargo fmt --all -- --checkis clean, andcargo check --workspace --all-targets --lockedcompletes with no warnings on a combined stack of the six backports being proposed together. Test execution is left to CI.