fix(core): fix main build errors - #2254
Merged
avantgardnerio merged 1 commit intoAug 8, 2026
Merged
Conversation
PR apache#2038 added `optional uint32 partition = 16` to `OperatorMetric` in the proto. PR apache#2042 was based on pre-apache#2038 main and added a test with three `OperatorMetric { … }` struct literals that don't set `partition`. The merge of apache#2042 skipped a rebase, so the combined tree stopped compiling on main (E0063 at 338, 341, 356). The other three literals in this file (394, 398, 414) already set `partition: None`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
avantgardnerio
changed the title
milenkovicm
approved these changes
Aug 8, 2026
milenkovicm
left a comment
milenkovicm
left a comment
Contributor
There was a problem hiding this comment.
Thanks @avantgardnerio ive ignored notification with that flaky test generating false alarms
Apologies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main is red on run 31258248064 with
E0063: missing field 'partition'indistributed_explain_analyze.rsat three test sites (338, 341, 356).Root cause is a merge-order collision, not a single-PR bug:
optional uint32 partition = 16toOperatorMetricinballista.proto.OperatorMetric { … }literals that don't setpartition.Three other literals in the same file (394, 398, 414) already set
partition: None; this PR brings the remaining three in line.Test plan
cargo clippy --all-targets --package ballista-core --all-features -- -D warningscargo fmt --all -- --check