fix: apply 1.11 Iceberg diff changes from #4991 to other versions#5020
Merged
Conversation
mbutrovich
changed the title
mbutrovich
changed the title
mbutrovich
commented
Jul 24, 2026
|
|
||
| assertThatThrownBy(() -> writeAndValidate(writeSchema, expectedSchema)) | ||
| - .has( | ||
| - new Condition<>( |
Contributor
Author
There was a problem hiding this comment.
We don't throw this exact class, but the check for the error message is still valid.
andygrove
approved these changes
Jul 24, 2026
Contributor
Author
|
Thanks for the quick review, @andygrove! I'll get this in once CI goes green to fix the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
mainbuilds fail the Iceberg builds for 1.8, 1.9, and 1.10 because I neglected to apply the same changes I made to 1.11 in #4991.What changes are included in this PR?
Apple the 1.11 Iceberg diff changes from #4991 to 1.8, 1.9, and 1.10.
How are these changes tested?
Existing CI. I'll stick the
run-iceberg-testslabel on here so we should run all versions likemainbuilds do. I should have done that on #4991.