chore: replace deprecated symbol literals with $"col" in tests - #5168
Merged
Conversation
Symbol literals ('col) are deprecated in Scala 2.13 and produce 63
compiler warnings under the Scala 2.13 profiles, which is by far the
largest single group of Scala warnings in the build. Replace them with
the equivalent $"col" string interpolator in TPCH.scala and
ParquetReadSuite.
No behavior change: both forms resolve through the same catalyst DSL
implicits to the same attribute.
andygrove
added a commit
to andygrove/datafusion-comet
that referenced
this pull request
Jul 31, 2026
The symbol literal ('col -> $"col") replacements in TPCH.scala and
ParquetReadSuite accounted for 63 of the warnings fixed here, which is
large enough to review on its own. They are now in apache#5168, so revert
those two files back to main to avoid overlapping with that PR.
andygrove
added a commit
to andygrove/datafusion-comet
that referenced
this pull request
Jul 31, 2026
The .toIterable protobuf builder fixes and the auto-application-to-() fixes were split out into apache#5173 and apache#5175. Remove them here so this PR is limited to the one-off warnings that have no category PR of their own. apache#5168 and apache#5170 already landed on main. [skip ci]
andygrove
added a commit
to andygrove/datafusion-comet
that referenced
this pull request
Jul 31, 2026
The .toIterable protobuf builder fixes and the auto-application-to-() fixes were split out into apache#5173 and apache#5175. Remove them here so this PR is limited to the one-off warnings that have no category PR of their own. apache#5168 and apache#5170 already landed on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue filed — this is a mechanical compiler-warning cleanup, split out of #5141 because it accounts for the largest single group of warnings on its own.
Rationale for this change
Symbol literals (
'col) are deprecated in Scala 2.13. They account for 63 of the 91 Scala warnings in the test sources under the 2.13 profiles — by far the largest single group of Scala compiler warnings in the build, and all of them are in two files. Splitting them out of #5141 keeps that PR reviewable and lets this purely mechanical change go in on its own.What changes are included in this PR?
'colreplaced with the equivalent$"col"string interpolator in:spark/src/test/scala/org/apache/spark/sql/TPCH.scala(62 occurrences — the TPC-H table schema definitions)spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala(1 occurrence)No behavior change: both forms resolve through the same Catalyst DSL implicits to the same attribute.
Table("region", ...)is reformatted onto multiple lines by spotless because the longer names push it past the line limit — that is the only non-substitution change.These are the last symbol literals in the repo, so this group of warnings drops to zero.
How are these changes tested?
No new tests — mechanical cleanup with no intended behavior change.
test-compilesucceeds on the default profile,-Pspark-3.5, and-Pspark-3.4.spotless:checkandscalastyle:checkpass.