feat: add ASOF join logical semantics#23829
Draft
Xuanwo wants to merge 4 commits into
Draft
Conversation
github-actions
Bot
added
sql
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23829 +/- ##
==========================================
- Coverage 80.75% 80.70% -0.06%
==========================================
Files 1089 1090 +1
Lines 368948 370377 +1429
Branches 368948 370377 +1429
==========================================
+ Hits 297952 298908 +956
- Misses 53237 53634 +397
- Partials 17759 17835 +76 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This is the logical-planning layer of the ASOF JOIN stack. It defines the
logical contract and planner behavior separately from the SQL frontend and
serialization formats.
GitHub shows the cumulative stack because fork branches cannot be selected as
upstream PR bases. The isolated diff for this layer is:
Xuanwo/datafusion@xuanwo/asof-physical...xuanwo/asof-logical
What changes are included in this PR?
LogicalPlan::AsOfJoin,AsOfJoin, andAsOfMatch.operators, equality-key types, and USING constraints.
LogicalPlanBuilderentry points and schema construction.pruning, filter pushdown, and physical planning.
owning stack layers add explicit support.
Are these changes tested?
Yes:
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo test -p datafusion --test core_integration test_asof_join_pushes_only_left_filters --all-featurescargo test -p datafusion-substrait asof_join_fails_closed_until_substrait_has_an_extension --all-featuresAre there any user-facing changes?
This adds logical-plan and builder APIs for ASOF joins. SQL syntax, DataFrame
APIs, and plan serialization are intentionally left to dependent stack PRs.
This PR should be reviewed and merged after #23828. After the dependency
squash-merges, this branch will be refreshed from
mainwithout rewriting itspublished history.