feat: add ASOF joins to DataFrame API#23831
Draft
Xuanwo wants to merge 6 commits into
Draft
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23831 +/- ##
==========================================
- Coverage 80.75% 80.73% -0.03%
==========================================
Files 1089 1090 +1
Lines 368948 370407 +1459
Branches 368948 370407 +1459
==========================================
+ Hits 297952 299053 +1101
- Misses 53237 53510 +273
- Partials 17759 17844 +85 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This is the DataFrame API layer of the ASOF JOIN stack. It exposes the logical
contract through the fluent API without coupling that API review to SQL parsing
or protobuf changes.
GitHub shows the cumulative stack because fork branches cannot be selected as
upstream PR bases. The isolated diff for this layer is:
Xuanwo/datafusion@xuanwo/asof-logical...xuanwo/asof-dataframe
What changes are included in this PR?
DataFrame::join_asoffor expression-based equality keys.DataFrame::join_asof_usingfor same-named equality keys.AsOfMatchandOperatorfrom the DataFusion prelude.Are these changes tested?
Yes:
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo test -p datafusion --test core_integration dataframe::join_asof --all-featuresAre there any user-facing changes?
Users can build ASOF joins through
DataFrame::join_asofandDataFrame::join_asof_using.This PR should be reviewed and merged after #23829. After its dependencies
squash-merge, this branch will be refreshed from
mainwithout rewriting itspublished history.