Perf: remove extra allocations for hex operations - #24057
Open
Rich-T-kid wants to merge 4 commits into
Open
Conversation
Rich-T-kid
force-pushed
the
rich-T-kid/avoid-hex-string-allocation
branch
from
August 3, 2026 05:27
edfa6cf to
15d22de
Compare
Rich-T-kid
marked this pull request as ready for review
August 3, 2026 05:31
Contributor
Author
|
@andygrove this is ready for review 👍 |
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Rich-T-kid
commented
Aug 3, 2026
Rich-T-kid
left a comment
Contributor
Author
There was a problem hiding this comment.
We may not need to deprecate this — just swapping out how DataFusion uses this internally may be enough, and it avoids a breaking API change.
Contributor
Author
Rich-T-kid
force-pushed
the
rich-T-kid/avoid-hex-string-allocation
branch
from
August 3, 2026 05:55
15d22de to
67cb73d
Compare
Rich-T-kid
force-pushed
the
rich-T-kid/avoid-hex-string-allocation
branch
from
August 3, 2026 05:56
67cb73d to
4b880e1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24057 +/- ##
==========================================
- Coverage 80.88% 80.88% -0.01%
==========================================
Files 1101 1101
Lines 375720 375787 +67
Branches 375720 375787 +67
==========================================
+ Hits 303895 303947 +52
- Misses 53729 53738 +9
- Partials 18096 18102 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Which issue does this PR close?
Rationale for this change
The digest functions hex-encode their output by allocating one String per row and then copying each of those into the output array (#23810)
What changes are included in this PR?
Are these changes tested?
existing test cover behavior.
Are there any user-facing changes?
yes,
encode_bytes()is being deprecated. This was apart of the public API