doc: add implementation guidelines for datafusion-spark - #24140
Open
Jefffrey wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
I didn't receive an answer regarding datatypes so I just put a view here; am open to changing it if others have differing opinions. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24140 +/- ##
==========================================
- Coverage 81.04% 81.04% -0.01%
==========================================
Files 1105 1105
Lines 380163 380163
Branches 380163 380163
==========================================
- Hits 308111 308107 -4
- Misses 53834 53836 +2
- Partials 18218 18220 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
andygrove
reviewed
Aug 6, 2026
| and compatibility. | ||
|
|
||
| Therefore, direct invocation tests should only be used to verify that the function is correctly implemented. | ||
| ### `simplify()` |
Member
There was a problem hiding this comment.
There is a challenge here on how to write sql logic tests to test both the simplify and the invoke_with_args implementations.
Do you have suggestions on how to address this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-sparkSpark Compatible Functions #15914 (comment)datafusion-sparkexpressions are missing the physical implementation #21959Rationale for this change
Set some guidelines for how UDFs should be implemented in
datafusion-spark. This is to align us on what we expect from UDFs, making it easier for contributors & reviewers alike.