Return from task execution if send fails as there is nothing more to do (faster cancel / limit) #3276
Conversation
| output.send(item).await.ok(); | ||
| // there is no place to send the error. | ||
| if let Err(_) = output.send(item).await { | ||
| return; |
There was a problem hiding this comment.
The change looks reasonable, but I think we should at least log a debug or warning message rather than silently consuming the error.
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I agree this looks like a nice change -- it will make cancelling a plan more efficient (the execution will be stopped sooner). Thanks @nvartolomei
cc @crepererum who added AbortOnDropMany initially
|
Thanks @nvartolomei -- this looks like a very nice improvement so I will merge it in and add a log message as a follow on PR |
alamb
changed the title
|
Benchmark runs are scheduled for baseline = 93a95c2 and contender = 7a53872. 7a53872 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
4 participants
This doesn't introduce much change in behaviour as the tasks were shut down (usually) by
AbortOnDropManyanyway.