Refactor Expr::GetIndexedField to use a struct #3838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
approved these changes
Oct 15, 2022
Comment on lines
177
to
179
| Expr::GetIndexedField(get_indexed_field) => { | ||
| let expr = create_physical_name(&get_indexed_field.expr, false)?; | ||
| Ok(format!("{}[{}]", expr, get_indexed_field.key)) |
Contributor
There was a problem hiding this comment.
I recommend this style so that if we ever change GetIndexedField the compiler will tell us all the places where a new field may be needed
Suggested change
| Expr::GetIndexedField(get_indexed_field) => { | |
| let expr = create_physical_name(&get_indexed_field.expr, false)?; | |
| Ok(format!("{}[{}]", expr, get_indexed_field.key)) | |
| Expr::GetIndexedField(GetIndexedField { expr, key }) => { | |
| let expr = create_physical_name(expr, false)?; | |
| Ok(format!("{}[{}]", expr, key)) |
jackwener
approved these changes
Oct 16, 2022
Member
|
@ygf11 There are some conflicts in this PR now, so I will move to draft until those are resolved - please mark this as ready for review once these are resolved. |
Contributor
Author
|
@alamb @andygrove @jackwener I resolved comment and conflicts, PTAL. |
alamb
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2175 and #3807
Rationale for this change
Refactor
Expr::GetIndexedFieldto use a struct.What changes are included in this PR?
Are there any user-facing changes?