Refactor Expr::GetIndexedField to use a struct
#3860
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesbluca
commented
Oct 17, 2022
| } | ||
| } | ||
|
|
||
| #[derive(Clone, PartialEq, Eq, Hash)] |
Author
There was a problem hiding this comment.
Overlooked it because I wasn't sure what expression GetIndexedField corresponds to, but should add a comment here explaining the purpose of this struct
charlesbluca
changed the title
Expr::GetIndexedField to use a struct
github-actions
bot
added
core
andygrove
reviewed
Oct 17, 2022
| } | ||
|
|
||
| #[derive(Clone, PartialEq, Eq, Hash)] | ||
| pub struct GetIndexedField { |
Member
There was a problem hiding this comment.
I think we can just re-use the docs from the Expr::GetIndexField enum variant here:
Suggested change
| pub struct GetIndexedField { | |
| /// Returns the field of a [`arrow::array::ListArray`] or [`arrow::array::StructArray`] by key | |
| pub struct GetIndexedField { |
17 tasks
Member
|
There is another PR open for the same work - #3838 |
Contributor
Author
|
Ah my bad completely missed that, happy to close in that case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #2175 and #3807.
Rationale for this change
Continuing the work outlined in #3807 to bring
Exprvariants more in line withLogicalPlanvariants.What changes are included in this PR?
Refactors
Expr::GetIndexedFieldto use a struct.Are there any user-facing changes?
No