Set versions to dependencies with path in benchmarks Cargo.toml file #4136
Conversation
| object_store = "0.5.0" | ||
| parquet = "26.0.0" | ||
| parquet-test-utils = { path = "../parquet-test-utils/" } | ||
| parquet-test-utils = { path = "../parquet-test-utils/", version = "0.1.0" } |
There was a problem hiding this comment.
Another issue is that we don't publish parquet-test-utils so we still can't publish this crate. This dependency is used in the parquet_filter_pushdown benchmark and not in tpch. I wonder if we should consider re-organizing these benchmarks into individual crates.
There was a problem hiding this comment.
Yeah, I agree there is some sort of impedance mismatch with the benchmarks at the moment (like are they something we ever want to run outside a source checkout) 🤔
| object_store = "0.5.0" | ||
| parquet = "26.0.0" | ||
| parquet-test-utils = { path = "../parquet-test-utils/" } | ||
| parquet-test-utils = { path = "../parquet-test-utils/", version = "0.1.0" } |
There was a problem hiding this comment.
Yeah, I agree there is some sort of impedance mismatch with the benchmarks at the moment (like are they something we ever want to run outside a source checkout) 🤔
|
Benchmark runs are scheduled for baseline = 2a834d1 and contender = 18c6a0b. 18c6a0b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
4 participants
Which issue does this PR close?
Closes #4134
Rationale for this change
See #4134
Are these changes tested?
Are there any user-facing changes?