Skip to content

Set versions to dependencies with path in benchmarks Cargo.toml file #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Set versions to dependencies with path in benchmarks Cargo.toml file #4136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions benchmarks/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,21 @@ snmalloc = ["snmalloc-rs"]

[dependencies]
arrow = "26.0.0"
datafusion = { path = "../datafusion/core" }
datafusion = { path = "../datafusion/core", version = "14.0.0" }
env_logger = "0.9"
futures = "0.3"
mimalloc = { version = "0.1", optional = true, default-features = false }
num_cpus = "1.13.0"
object_store = "0.5.0"
parquet = "26.0.0"
parquet-test-utils = { path = "../parquet-test-utils/" }
parquet-test-utils = { path = "../parquet-test-utils/", version = "0.1.0" }
Copy link
Member

@andygrove andygrove Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another issue is that we don't publish parquet-test-utils so we still can't publish this crate. This dependency is used in the parquet_filter_pushdown benchmark and not in tpch. I wonder if we should consider re-organizing these benchmarks into individual crates.

Copy link
Contributor

@alamb alamb Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree there is some sort of impedance mismatch with the benchmarks at the moment (like are they something we ever want to run outside a source checkout) 🤔

rand = "0.8.4"
serde = { version = "1.0.136", features = ["derive"] }
serde_json = "1.0.78"
snmalloc-rs = { version = "0.3", optional = true }
structopt = { version = "0.3", default-features = false }
test-utils = { path = "../test-utils/" }
test-utils = { path = "../test-utils/", version = "0.1.0" }
tokio = { version = "^1.0", features = ["macros", "rt", "rt-multi-thread", "parking_lot"] }

[dev-dependencies]
datafusion-proto = { path = "../datafusion/proto" }
datafusion-proto = { path = "../datafusion/proto", version = "14.0.0" }