Skip to content

refactor: reorganize theta family mods and add key-only sketch views - #178

Merged
tisonkun merged 1 commit into
apache:mainfrom
ariesdevil:dev_theta
Aug 2, 2026
Merged

refactor: reorganize theta family mods and add key-only sketch views#178
tisonkun merged 1 commit into
apache:mainfrom
ariesdevil:dev_theta

Conversation

@ariesdevil

@ariesdevil ariesdevil commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Group the shared Theta, Theta, and Tuple implementations under theta_family.
    • Preserve the existing public module paths through re-exports.
  • Introduce key-only sketch views for operations that only consume retained hashes.
    • Update Jaccard similarity and the B side of A-not-B to avoid cloning Tuple summaries.
    • Keep full retained-entry views for operations such as union and intersection.

The theta family becomes:

datasketches/src/theta_family/
├── common/
├── theta/
├── tuple/
└── mod.rs

@tisonkun tisonkun changed the title refactor(theta_family): reorganize theta family mods and add key-only sketch views refactor: reorganize theta family mods and add key-only sketch views Aug 2, 2026

@tisonkun tisonkun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM.

But I'd still prefer:

theta
thetacommon
tuple

.. structure.

But I can submit a follow-up PR to demonstrate that structure tomorrow.

@tisonkun
tisonkun merged commit 5433a8e into apache:main Aug 2, 2026
10 checks passed
@tisonkun

tisonkun commented Aug 2, 2026

Copy link
Copy Markdown
Member

Now I know you use a theta_family mod to keep several methods pub(super).

@tisonkun

tisonkun commented Aug 2, 2026

Copy link
Copy Markdown
Member

I pushed #179 to rename theta_family to thetafamily. It's not exported so it makes no difference from user interfaces, but keep our top-level modules no separator which provides a stable style (my bias, yes).

@ariesdevil
ariesdevil deleted the dev_theta branch August 3, 2026 03:52
@ariesdevil

Copy link
Copy Markdown
Contributor Author

But I'd still prefer:

theta
thetacommon
tuple

.. structure.

Actually, I like the original structure too, but I don't want to put thetacommon at the top level, so I came up with a compromise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants