[feature-6071][plugin] add datasource plugin. (#6071)#6361
Merged
CalvinKirs merged 46 commits intoapache:devfrom Nov 9, 2021
Merged
[feature-6071][plugin] add datasource plugin. (#6071)#6361CalvinKirs merged 46 commits intoapache:devfrom
CalvinKirs merged 46 commits intoapache:devfrom
Conversation
* remove the dependency of datasource in common and task-plugin module. * the new datasource-api module provides data source connection acquisition. * add sqlserver data source plug-in.
…duler into feature-6071 � Conflicts: � dolphinscheduler-dist/src/main/provisio/dolphinscheduler.xml � dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/runner/TaskExecuteThread.java � dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/consumer/TaskPriorityQueueConsumerTest.java
…duler into feature-6071
…duler into feature-6071 � Conflicts: � dolphinscheduler-dist/src/main/provisio/dolphinscheduler.xml
…inscheduler into feature-6071 � Conflicts: � dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HadoopUtils.java � dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java
Codecov Report
@@ Coverage Diff @@
## dev #6361 +/- ##
============================================
- Coverage 41.43% 41.08% -0.36%
- Complexity 3600 3631 +31
============================================
Files 625 659 +34
Lines 26103 26425 +322
Branches 2847 2863 +16
============================================
+ Hits 10816 10856 +40
- Misses 14310 14585 +275
- Partials 977 984 +7
Continue to review full report at Codecov.
|
Member
…duler into feature-6071 � Conflicts: � dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/UpgradeDao.java � dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/DolphinSchedulerPlugin.java � pom.xml
caishunfeng
reviewed
Nov 9, 2021
| requireNonNull(datasourceChannelFactory, "taskChannelFactory is null"); | ||
|
|
||
| if (datasourceClientFactoryMap.putIfAbsent(datasourceChannelFactory.getName(), datasourceChannelFactory) != null) { | ||
| throw PluginException.getInstance(format("Task Plugin '%s' is already registered", datasourceChannelFactory.getName())); |
Contributor
|
LGTM. Thank's for your great work. |
kezhenxu94
reviewed
Nov 9, 2021
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class DataSourcePluginManager extends AbstractDolphinPluginManager { |
Member
Contributor
Author
There was a problem hiding this comment.
In order to facilitate development and use, it is also what I want. I look forward to further communication with you
Contributor
Author
There was a problem hiding this comment.
Maybe you can take a look at this PR and look forward to your suggestions #6093
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove the dependency of datasource in common and task-plugin module.
the new datasource-api module provides data source connection acquisition.
add all data source plug-in.
this closes #6071