Refactor registry plugin and simplify its usage#6712
Refactor registry plugin and simplify its usage#6712CalvinKirs merged 1 commit intoapache:devfrom kezhenxu94:plugin-refactor/registry
Conversation
|
@CalvinKirs @dailidong @lenboo can you please take a look? |
Codecov Report
@@ Coverage Diff @@
## dev #6712 +/- ##
============================================
+ Coverage 37.69% 37.90% +0.20%
+ Complexity 3236 3233 -3
============================================
Files 650 642 -8
Lines 26546 26378 -168
Branches 2876 2858 -18
============================================
- Hits 10006 9998 -8
+ Misses 15621 15462 -159
+ Partials 919 918 -1
Continue to review full report at Codecov.
|
|
SonarCloud Quality Gate failed. |
| registry.plugin.dir=./dolphinscheduler-dist/target/dolphinscheduler-dist-2.0.0-SNAPSHOT/lib/plugin/registry/zookeeper | ||
| registry.plugin.name=zookeeper | ||
| registry.servers=127.0.0.1:2181 | ||
| dolphinscheduler/dolphinscheduler-e2e @kezhenxu94 |
There was a problem hiding this comment.
is it necessary? '@kezhenxu94'
This is an example to list "maintainers" for some specific modules, github will automatically request their review when these modules are modified in pull requests, you and other maintainers can also add the modules you are responsible for. Does it make sense to you?
|
good job |








Purpose of the pull request
This pull request refactors the registry plugin mechanism and simplifies its usage and registry plugin development.
Now the configuration to run locally and in production is the same so users won't get errors like #6129 #5643 and #5793
Brief change log