Skip to content

[Fix-7538] [server] Fix when there is a forbidden node in dag, the execution flow is abnormal#7613

Merged
ruanwenjun merged 9 commits intoapache:devfrom
vinnielhj:dev
Dec 28, 2021
Merged

[Fix-7538] [server] Fix when there is a forbidden node in dag, the execution flow is abnormal#7613
ruanwenjun merged 9 commits intoapache:devfrom
vinnielhj:dev

Conversation

@vinnielhj
Copy link
Contributor

fix #7538;
While fixing the bug, I reformatted the code using checkStyle

@vinnielhj vinnielhj closed this Dec 24, 2021
… dev

� Conflicts:
�	dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
@vinnielhj vinnielhj reopened this Dec 24, 2021
hongjie.li added 2 commits December 24, 2021 17:43
# Conflicts:
#	dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2021

Codecov Report

Merging #7613 (312e6e3) into dev (2d73083) will decrease coverage by 0.02%.
The diff coverage is 1.51%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #7613      +/-   ##
============================================
- Coverage     41.15%   41.12%   -0.03%     
+ Complexity     3665     3662       -3     
============================================
  Files           641      641              
  Lines         26539    26546       +7     
  Branches       2967     2967              
============================================
- Hits          10921    10918       -3     
- Misses        14590    14601      +11     
+ Partials       1028     1027       -1     
Impacted Files Coverage Δ
...er/server/master/runner/WorkflowExecuteThread.java 9.96% <1.51%> (-0.09%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.11% <0.00%> (-1.41%) ⬇️
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <0.00%> (ø)
...er/api/service/impl/TaskDefinitionServiceImpl.java 31.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d73083...312e6e3. Read the comment docs.

@ruanwenjun ruanwenjun added the bug Something isn't working label Dec 26, 2021
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 3af4d76 into apache:dev Dec 28, 2021
caishunfeng pushed a commit to caishunfeng/dolphinscheduler that referenced this pull request Jan 14, 2022
caishunfeng pushed a commit to caishunfeng/dolphinscheduler that referenced this pull request Jan 14, 2022
zhongjiajie pushed a commit that referenced this pull request Jan 14, 2022
* [cherry-pick-2.0.3]Correct typo in English README #7695

* Update NOTICE year (#7784)

* [BUG] Repair JDBC connection of Oracle (#7883)

* [cherry-pick-2.0.3][Fix-7538] [server] Fix when there is a forbidden node in dag, the execution flow is abnormal #7613

* [cherry-pick-2.0.3][Fix-7825] Remedy the value of create time and update time to be current time when importing a process json file. #7828

* [FIX-7732][fix] fix column 'is_directory' of table `t_ds_resources` type error in PG database (#7898)

Fix column 'is_directory' of table t_ds_resources type error in PG database
This closes #7732

Co-authored-by: Brennan Fox <brnnnfx@users.noreply.github.com>
Co-authored-by: Kirs <acm_master@163.com>
Co-authored-by: X&Z <980813351@qq.com>
Co-authored-by: caishunfeng <534328519@qq.com>
Co-authored-by: 天仇 <532066967@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working first time contributor First-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [server] when there is a forbidden node in dag, the execution flow is abnormal

4 participants