Skip to content

[FIX-7732][fix] fix column 'is_directory' of table t_ds_resources type error in PG database#7898

Merged
ruanwenjun merged 3 commits intoapache:devfrom
jim-parsons:FIX-7732-1
Jan 9, 2022
Merged

[FIX-7732][fix] fix column 'is_directory' of table t_ds_resources type error in PG database#7898
ruanwenjun merged 3 commits intoapache:devfrom
jim-parsons:FIX-7732-1

Conversation

@jim-parsons
Copy link
Contributor

@jim-parsons jim-parsons commented Jan 8, 2022

Purpose of the pull request

fix column 'is_directory' of table t_ds_resources type error in PG database

Brief change log

  1. alter column from int to boolean. In the origin Resource.java ,isDirectory has a default value, so in the init sql set column default false
  2. Format class Resource.java

can close #7732

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

…pe error in PG database

[FIX-7732][fix] fix column 'is_directory' of table t_ds_resources type error in PG database

1. alter column from int to boolean

This closes apache#7732
…ype error in PG database

[FIX-7732][fix] fix column 'is_directory' of table `t_ds_resources` type error in PG database

1. alter column from int to boolean. In the origin `Resource.java` ,`isDirectory` has a default value, so in the init sql set column default false
2. Format class `Resource.java`

This closes apache#7732
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2022

Codecov Report

Merging #7898 (9e6545c) into dev (57f000e) will increase coverage by 0.00%.
The diff coverage is 47.56%.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev    #7898   +/-   ##
=========================================
  Coverage     40.98%   40.99%           
- Complexity     3694     3695    +1     
=========================================
  Files           637      637           
  Lines         27058    27058           
  Branches       3073     3073           
=========================================
+ Hits          11090    11092    +2     
+ Misses        14899    14894    -5     
- Partials       1069     1072    +3     
Impacted Files Coverage Δ
...g/apache/dolphinscheduler/dao/entity/Resource.java 47.56% <47.56%> (ø)
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.52% <0.00%> (+1.40%) ⬆️
...org/apache/dolphinscheduler/remote/utils/Host.java 40.00% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57f000e...9e6545c. Read the comment docs.

ruanwenjun
ruanwenjun previously approved these changes Jan 8, 2022
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ype error in PG database

[FIX-7732][fix] fix column 'is_directory' of table `t_ds_resources` type error in PG database

1. alter column from int to boolean. In the origin `Resource.java` ,`isDirectory` has a default value, so in the init sql set column default false
2. Format class `Resource.java`

This closes apache#7732
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ruanwenjun ruanwenjun merged commit 361d68d into apache:dev Jan 9, 2022
caishunfeng pushed a commit to caishunfeng/dolphinscheduler that referenced this pull request Jan 14, 2022
…ype error in PG database (apache#7898)

Fix column 'is_directory' of table t_ds_resources type error in PG database
This closes apache#7732
caishunfeng pushed a commit to caishunfeng/dolphinscheduler that referenced this pull request Jan 14, 2022
…ype error in PG database (apache#7898)

Fix column 'is_directory' of table t_ds_resources type error in PG database
This closes apache#7732
zhongjiajie pushed a commit that referenced this pull request Jan 14, 2022
* [cherry-pick-2.0.3]Correct typo in English README #7695

* Update NOTICE year (#7784)

* [BUG] Repair JDBC connection of Oracle (#7883)

* [cherry-pick-2.0.3][Fix-7538] [server] Fix when there is a forbidden node in dag, the execution flow is abnormal #7613

* [cherry-pick-2.0.3][Fix-7825] Remedy the value of create time and update time to be current time when importing a process json file. #7828

* [FIX-7732][fix] fix column 'is_directory' of table `t_ds_resources` type error in PG database (#7898)

Fix column 'is_directory' of table t_ds_resources type error in PG database
This closes #7732

Co-authored-by: Brennan Fox <brnnnfx@users.noreply.github.com>
Co-authored-by: Kirs <acm_master@163.com>
Co-authored-by: X&Z <980813351@qq.com>
Co-authored-by: caishunfeng <534328519@qq.com>
Co-authored-by: 天仇 <532066967@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [SQL] field ‘is_directory’ in t_ds_resources table has error type in PostgreSQL database

3 participants