[fix](doc) milliseconds-add/week: en/zh cleanup (BIGINT example, ZH duplicates, ZH fence on table)#3834
Merged
morningman merged 1 commit intoMay 30, 2026
Conversation
…uplicates, ZH fence on table)
milliseconds-add.md en: add an example for `delta` exceeding INT max
(2^31 - 1), which the function still computes correctly via BIGINT.
Output captured from a fresh Doris 4.1.1 cluster.
milliseconds-add.md zh: remove five copy-paste duplicate examples that
re-emitted examples 1-5 verbatim at the bottom of the 举例 section.
week.md zh: the `Mode` definition table was wrapped in a ```sql fence,
which makes the doc verifier feed pipe-delimited prose ('|Mode |...') to
the cluster as SQL. Removed the fence so the table renders as a regular
markdown table (like the en page already does).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
morningman
pushed a commit
that referenced
this pull request
May 30, 2026
…EN DESC-TABLE example expansion (#3847) ## Summary Mechanical port of the 4.x fixes in #3830, #3831, #3832, #3834, #3835, #3836 to dev/master. Every change here was verified to still be needed on today's master build (cluster deployed from selectdb-qa-test tarball, 5.14 GB). Three 4.x fixes turned out to be already-applied on dev and are **not** included in this PR (skipping): - log10 ZH (NULL/NaN examples already in dev) - strleft ZH (example 9 already removed in dev) - milliseconds-add EN (BIGINT-range example already in dev) ## Files (15) ### ZH (`i18n/zh-CN/.../current/`) - **arrays-overlap.md** — remove two stray `'` after closing fences - **unix-timestamp.md** — add missing semicolon after `select unix_timestamp('1007-11-30 10:30:19')` - **DESC-TABLE.md** — drop `demo.` qualifier (`DESC demo.test_table ALL` → `DESC test_table ALL`); fix stale `DUP_KEYS` cell → `UNIQUE_KEYS` (matches the page's own `UNIQUE KEY(user_id)` setup) - **week.md** — drop the ` ```sql ` wrapper around the Mode definition markdown table - **milliseconds-add.md** — remove 5 copy-paste duplicate examples; fix BIGINT-range example expected output (\"returns NULL\" → actual `2023-10-03 12:33:32.083000`) - **9 array / bitmap / aggregate / string files** — fence-flavor parity (` ``` ` or ` ```text ` → ` ```sql ` where the block contains runnable SQL). `trim-in.md` additionally adds example 3 (TRIM comparison) that was missing. ### EN (`docs/`) - **DESC-TABLE.md** — add a CREATE TABLE setup block, backport the two ZH-only examples (Comment column via `show_column_comment_in_describe`, and `DESC ... ALL`). The Comment-column behavior was already mentioned in the Return-Value section but never exemplified. ## Verification Verified end-to-end against today's master cluster — every added example runs cleanly, behaviors documented are the same on master as on 4.1.1 (no master-side regression on log10/MINUTE/SPLIT_PART/UNHEX/count_by_enum either). ## Related 4.x PRs #3830 #3831 #3832 #3834 #3835 #3836 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
morningman
pushed a commit
that referenced
this pull request
May 30, 2026
…orner-case adds (en+zh) (#3848) ## Summary Mechanical port of the 4.x fixes in #3833, #3837, #3838, #3839 to dev/master. Verified against today's master build (selectdb-qa-test tarball). **Skipped** (already applied on dev): - strleft.md ZH dedup (#3837) - milliseconds-add.md EN BIGINT-range example (#3834 EN-side; the ZH duplicate-removal piece is in the sibling PR) ## Files (13) ### EN string-functions - **from-base64.md, instr.md, length.md, locate.md, lpad.md** — backport corner-case examples (NULL / empty / multi-byte UTF-8 / numeric / etc.) added in #3833 - **rtrim.md** — add the LENGTH-based 'default-only-strips-ASCII-space' example (#3837) - **substring.md** — add the missing 'empty source string' example + 'NULL passed directly' (#3839) - **trim.md** — replace example 2's prose + expected output (`trim('ababccaab', 'ab')` is `cca`, not `ababcca` — trim repeatedly strips from both ends), plus the UTF-8 multi-byte-pattern example (#3839) ### EN other-functions - **field.md** — full replace with 4.x post-fix version: adds CREATE TABLE setup for `baseall` and `class_test` (which the page references but never created), adds a NULL row to `class_test`, adds DESC and NULLS FIRST examples that exercise NULL handling (#3789 + #3839 combined) ### ZH - **field.md** — add the simple `SELECT FIELD(2, 3, 1, 2, 5)` example (#3839) - **ltrim.md** — rewrite example 3 with correct expected output; LTRIM strips ASCII space only, NOT `\t`/`\n`, so the result still contains the tab/newline. Switched to a LENGTH() comparison for clarity (#3838) - **substring.md** — add the SUBSTR alias example (#3839) - **trim.md** — add three examples (no-match returns original; repeated pattern strips until exhausted; asymmetric removal with multi-char pattern). Also drop a trailing `;;` typo (#3839) ## Verification Verified end-to-end against today's master cluster — all added / modified examples behave identically on master as on 4.1.1, so the doc fixes apply unchanged. ## Related 4.x PRs #3833 #3837 #3838 #3839 (and #3789 for the field.md setup blocks). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small en/zh cleanups in the date-time function pages, all surfaced by the doc verifier on Doris 4.1.1:
milliseconds-add.md(en) — add an example fordeltaexceeding INT max (2^31 - 1). The function still computes correctly via BIGINT; ZH had this example, EN did not. Output captured from a fresh cluster.milliseconds-add.md(zh) — remove five duplicate examples. Lines 82-117 of the ZH page re-emitted examples 1-5 verbatim at the bottom of the 举例 section (no new content), almost certainly a copy-paste accident.week.md(zh) — theModedefinition table was wrapped in a```sqlfence, which makes the doc verifier feed pipe-delimited prose (|Mode |星期的第一天 |...) to the cluster as SQL. Removed the fence so the table renders as a regular markdown table (like the EN page already does).Verification
SELECT MILLISECONDS_ADD('2023-09-08 16:02:08.435', 2147483648)on Doris 4.1.1 returns2023-10-03 12:33:32.083000, matching the documented expected output.🤖 Generated with Claude Code