[fix](doc) dev: backport 4.x zh fence / typo / DESC-TABLE cleanups + EN DESC-TABLE example expansion#3847
Merged
morningman merged 1 commit intoMay 30, 2026
Conversation
…EN DESC-TABLE example expansion Mechanical port of the 4.x fixes in apache#3830, apache#3831, apache#3832, apache#3834, apache#3835, apache#3836 to dev/master. Every change here was verified to still be needed on today's master build (cluster deployed from selectdb-qa-test tarball, 5.14 GB) — 3 of the 4.x fixes turned out to be already-applied on dev and are NOT included in this PR (log10 ZH NULL/NaN examples, strleft ZH dedup, milliseconds-add EN BIGINT example). Files changed: ZH (i18n/zh-CN/.../current/): * arrays-overlap.md — remove two stray `'` after closing fences that left CommonMark fence-parsing in a broken state. * unix-timestamp.md — add missing semicolon after `select unix_timestamp( '1007-11-30 10:30:19')` so the next ASCII row isn't interpreted as part of the same SQL statement. * DESC-TABLE.md — `DESC demo.test_table ALL` -> `DESC test_table ALL` (page never creates `demo`). — stale `DUP_KEYS` cell -> `UNIQUE_KEYS`, matching the page's own `UNIQUE KEY(user_id)` setup. * week.md — drop the ```sql wrapper around the Mode definition markdown table (it shouldn't be a code fence at all). * milliseconds-add.md — drop 5 copy-paste duplicate examples that re-emitted examples 1-5 at the bottom of the section. — fix the BIGINT-range example's expected output ('returns NULL' -> the actual result `2023-10-03 12:33:32.083000`). * array-contains.md / array-enumerate-uniq.md / array-first-index.md / array-first.md / array-exists.md / bitmap-hash.md / to-bitmap.md / collect-list.md / trim-in.md — fence-flavor parity: ``` (or ```text) -> ```sql where the block contains runnable SQL, so the doc verifier treats them consistently. trim-in.md additionally backports example 3 (TRIM-comparison) that was previously missing. EN (docs/): * DESC-TABLE.md — add a CREATE TABLE setup block, the existing 'Display Base Table Schema' example already there, then backport the two ZH-only examples (Comment column via `show_column_comment_in_describe`, and `DESC ... ALL`). The `Comment` paragraph was already in the dev page's Return-Value section but the example was missing; the DESC-ALL example was missing entirely. Verified end-to-end against today's master cluster: every added example runs cleanly; behaviors documented are the same on master as on 4.1.1 for all fixes touched here (no master-side regression). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mechanical port of the 4.x fixes in #3830, #3831, #3832, #3834, #3835, #3836 to dev/master. Every change here was verified to still be needed on today's master build (cluster deployed from selectdb-qa-test tarball, 5.14 GB).
Three 4.x fixes turned out to be already-applied on dev and are not included in this PR (skipping):
Files (15)
ZH (
i18n/zh-CN/.../current/)'after closing fencesselect unix_timestamp('1007-11-30 10:30:19')demo.qualifier (DESC demo.test_table ALL→DESC test_table ALL); fix staleDUP_KEYScell →UNIQUE_KEYS(matches the page's ownUNIQUE KEY(user_id)setup)```sqlwrapper around the Mode definition markdown table2023-10-03 12:33:32.083000)```or```text→```sqlwhere the block contains runnable SQL).trim-in.mdadditionally adds example 3 (TRIM comparison) that was missing.EN (
docs/)show_column_comment_in_describe, andDESC ... ALL). The Comment-column behavior was already mentioned in the Return-Value section but never exemplified.Verification
Verified end-to-end against today's master cluster — every added example runs cleanly, behaviors documented are the same on master as on 4.1.1 (no master-side regression on log10/MINUTE/SPLIT_PART/UNHEX/count_by_enum either).
Related 4.x PRs
#3830 #3831 #3832 #3834 #3835 #3836
🤖 Generated with Claude Code