[test](feut) fix testShouldWarmUpPerformanceRepeatedCycles200k - #66081
Merged
bobhan1 merged 1 commit intoJul 27, 2026
Merged
Conversation
### What problem does this PR solve? Issue Number: None Related PR: apache#65153 Problem Summary: The repeated-cycle cache hotspot performance test used a 1-second average threshold even though the equivalent 200K-table single-cycle test allows 1.5 seconds. CI hosts occasionally exceeded 1 second while preserving correct matching results. Align the repeated-cycle threshold with the existing 1.5-second allowance and update the assertion message. ### Release note None ### Check List (For Author) - Test: Unit Test - ./run-fe-ut.sh --run org.apache.doris.cloud.CacheHotspotManagerTableFilterTest#testShouldWarmUpPerformanceRepeatedCycles200k - Behavior changed: No - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
bobhan1
marked this pull request as ready for review
July 27, 2026 03:42
Contributor
Author
|
run buildall |
bobhan1
changed the title
testShouldWarmUpPerformanceRepeatedCycles200k
Contributor
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review opinion: approve.
The threshold alignment looks good. The five-cycle test still verifies exact matching for all 1,000,000 calls, and its 1.5-second per-cycle average now matches the existing single-cycle 200K-table oracle. Because OnTablesFilter is immutable and each call uses the same precompiled rule set, the average remains a useful sustained-throughput guard while reducing sensitivity to isolated CI scheduling or GC pauses.
Critical checkpoint conclusions:
- Goal and proof: the focused test-only change accomplishes the stated anti-flakiness goal without altering correctness coverage.
- Scope: minimal and clear; only the threshold and matching assertion message change.
- Concurrency, lifecycle, and locking: no production or shared-state behavior changes; not applicable to this patch.
- Configuration, compatibility, persistence, data writes, and FE-BE propagation: no changes; not applicable.
- Parallel paths and conditions: the revised bound is consistent with the neighboring single-cycle 200K path; production callers remain unchanged.
- Tests and results: the exact match-count assertion and broader 10K/50K/200K/500K, selective, and multi-rule coverage remain intact. No result files change. Per the review-run instructions, I did not execute builds or tests.
- Performance: the 1.5-second bound retains a meaningful regression signal and is well below the default 60-second refresh interval. The microbenchmark's omission of catalog traversal/logging and its averaging behavior predate this patch.
- Observability and other concerns: no runtime observability change is needed, and I found no additional correctness or performance issue.
User focus: no additional review focus was provided; I reviewed the whole PR.
gavinchou
approved these changes
Jul 27, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
Contributor
TPC-H: Total hot run time: 29239 ms |
Contributor
TPC-DS: Total hot run time: 178103 ms |
Contributor
ClickBench: Total hot run time: 25.02 s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: #65153
Problem Summary: The repeated-cycle cache hotspot performance test used a 1-second average threshold even though the equivalent 200K-table single-cycle test allows 1.5 seconds. CI hosts occasionally exceeded 1 second while preserving correct matching results. This change aligns the repeated-cycle threshold with the existing 1.5-second allowance and updates the assertion message.
Release note
None
Check List (For Author)
Test command:
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)