[fix](fe) Restrict frontend config updates to root in cloud mode - #66478
Open
gavinchou wants to merge 4 commits into
Open
[fix](fe) Restrict frontend config updates to root in cloud mode#66478gavinchou wants to merge 4 commits into
gavinchou wants to merge 4 commits into
Conversation
Restore the cloud-mode root-only authorization check for ADMIN SET FRONTEND CONFIG that existed in the legacy DDL executor. The Nereids command retained the global ADMIN privilege check but omitted the root restriction. Add a regression test that verifies an ordinary admin is rejected while root remains allowed in cloud mode.
gavinchou
requested review from
924060929,
englefly,
morrySnow and
starocean999
as code owners
August 5, 2026 07:55
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 29058 ms |
Contributor
TPC-DS: Total hot run time: 166632 ms |
Contributor
ClickBench: Total hot run time: 23.84 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
1 similar comment
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 28781 ms |
Contributor
TPC-DS: Total hot run time: 166189 ms |
Contributor
ClickBench: Total hot run time: 23.94 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary:
The Nereids migration of
ADMIN SET FRONTEND CONFIGretained the globalADMINprivilege check but omitted the cloud-mode root-only restriction from the legacy DDL executor. This PR restores that restriction: in cloud mode, an ordinary admin is rejected and root remains allowed. Non-cloud behavior is unchanged.Release note
Restrict
ADMIN SET FRONTEND CONFIGto root in cloud mode.Check List (For Author)
Test
AdminSetFrontendConfigCommandTest#testCloudAdminCannotSetFrontendConfigbuild.sh --feBehavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)