Skip to content

[fix](fe) Restrict frontend config updates to root in cloud mode #66478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gavinchou wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[fix](fe) Restrict frontend config updates to root in cloud mode #66478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5b6730
[fix](fe) Restrict frontend config updates to root in cloud mode
gavinchou Aug 5, 2026
3c8219a
Merge branch 'master' into gavin-fix-cloud-root-admin-set-config
gavinchou Aug 5, 2026
d922c16
Merge branch 'master' into gavin-fix-cloud-root-admin-set-config
gavinchou Aug 6, 2026
26d1faa
Merge branch 'master' into gavin-fix-cloud-root-admin-set-config
gavinchou Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...ain/java/org/apache/doris/nereids/trees/plans/commands/AdminSetFrontendConfigCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,13 @@
import org.apache.doris.analysis.RedirectStatus;
import org.apache.doris.catalog.Env;
import org.apache.doris.common.AnalysisException;
import org.apache.doris.common.Config;
import org.apache.doris.common.ConfigBase;
import org.apache.doris.common.DdlException;
import org.apache.doris.common.ErrorCode;
import org.apache.doris.common.ErrorReport;
import org.apache.doris.common.UserException;
import org.apache.doris.mysql.privilege.Auth;
import org.apache.doris.mysql.privilege.PrivPredicate;
import org.apache.doris.nereids.trees.plans.PlanType;
import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
Expand Down Expand Up @@ -92,6 +95,11 @@ public void validate() throws UserException {
if (type != NodeType.FRONTEND) {
throw new AnalysisException("Only support setting Frontend configs now");
}

if (Config.isCloudMode()
&& !ConnectContext.get().getCurrentUserIdentity().getUser().equals(Auth.ROOT_USER)) {
throw new DdlException("Unsupported operation");
}
}

@Override
Expand Down
27 changes: 27 additions & 0 deletions ...java/org/apache/doris/nereids/trees/plans/commands/AdminSetFrontendConfigCommandTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package org.apache.doris.nereids.trees.plans.commands;

import org.apache.doris.analysis.RedirectStatus;
import org.apache.doris.analysis.UserIdentity;
import org.apache.doris.catalog.Env;
import org.apache.doris.common.AnalysisException;
import org.apache.doris.common.CaseSensibility;
Expand Down Expand Up @@ -46,6 +47,32 @@ public void testNormal() throws Exception {
.startsWith("ADMIN SET FRONTEND CONFIG"));
}

@Test
public void testCloudAdminCannotSetFrontendConfig() {
String originalDeployMode = Config.deploy_mode;
String originalCloudUniqueId = Config.cloud_unique_id;
boolean originalEnableUdfInLoad = Config.enable_udf_in_load;
UserIdentity originalUserIdentity = connectContext.getCurrentUserIdentity();
try {
Config.deploy_mode = "cloud";
Config.cloud_unique_id = "";
connectContext.setCurrentUserIdentity(UserIdentity.ADMIN);

IllegalStateException exception = Assertions.assertThrows(IllegalStateException.class,
() -> executeSql("admin set frontend config(\"enable_udf_in_load\" = \"true\");"));
Assertions.assertEquals("errCode = 2, detailMessage = Unsupported operation", exception.getMessage());

connectContext.setCurrentUserIdentity(UserIdentity.ROOT);
Assertions.assertDoesNotThrow(
() -> executeSql("admin set frontend config(\"enable_udf_in_load\" = \"true\");"));
} finally {
connectContext.setCurrentUserIdentity(originalUserIdentity);
Config.deploy_mode = originalDeployMode;
Config.cloud_unique_id = originalCloudUniqueId;
Config.enable_udf_in_load = originalEnableUdfInLoad;
}
}

@Test
public void testRedirectStatus() {
String sql = "admin set frontend config(\"alter_table_timeout_second\" = \"60\");";
Expand Down
Loading