Unified logging framework - #1139
Closed
jianpeng-chen wants to merge 9 commits into
Closed
Conversation
…-logging-framework
…samples into unitify-logging-framework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
dubbo-samples-environment-keysanddubbo-samples-callbackmodules utilized the SLF4J logging framework in conjunction with Logback. The inclusion of Logback was propagated through thedubbo-zookeeper-curator5-spring-boot-starterdependency. This setup resulted in an inconsistency with the project's logging framework. Furthermore, with recent updates to the related dependencies, the SLF4J provider was no longer being passed down to the project, leading to a missing logging implementation.To address these issues, this PR includes the following modifications:
Update dubbo version to 3.3.0-beta.2 (this version of
dubbo-zookeeper-curator5-spring-boot-starterdoes not introduce the logging implementation)Introduce Log4j2 dependency
spring-boot-starter-log4j2