Skip to content

docs(extension): Fix comments for ActivateComparator and WrapperCompa… - #15649

Closed
lokidundun wants to merge 1 commit into
apache:3.3from
lokidundun:3.3
Closed

docs(extension): Fix comments for ActivateComparator and WrapperCompa…#15649
lokidundun wants to merge 1 commit into
apache:3.3from
lokidundun:3.3

Conversation

@lokidundun

Copy link
Copy Markdown

…rator

What is the purpose of the change?

优化 ActivateComparatorWrapperComparator 的类注释:

  1. 修正 WrapperComparator 原注释中错误的类名引用(比如旧注释可能误导为 OrderComparator)。
  2. 补充清晰的功能说明,让其他开发者更容易理解这两个比较器的作用。
  3. 保持代码文档与实际逻辑一致,提升 Dubbo 项目的可读性和可维护性。

Checklist

  • Make sure there is a GitHub_issue field for the change.
    本次修改是代码注释的优化,属于文档级小改进,未关联特定 Issue。
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
    本次修改仅涉及注释优化,无逻辑变更,因此无需单元测试。
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter

codecov-commenter commented Aug 21, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.02%. Comparing base (c831fef) to head (a1e757b).
⚠️ Report is 254 commits behind head on 3.3.

Additional details and impacted files
@@            Coverage Diff            @@
##                3.3   #15649   +/-   ##
=========================================
  Coverage     61.01%   61.02%           
- Complexity    11704    11720   +16     
=========================================
  Files          1910     1910           
  Lines         86806    86806           
  Branches      13100    13100           
=========================================
+ Hits          52968    52971    +3     
+ Misses        28419    28418    -1     
+ Partials       5419     5417    -2     
Flag Coverage Δ
integration-tests-java21 33.00% <ø> (-0.01%) ⬇️
integration-tests-java8 33.14% <ø> (+0.01%) ⬆️
samples-tests-java21 32.68% <ø> (-0.01%) ⬇️
samples-tests-java8 30.44% <ø> (+0.02%) ⬆️
unit-tests-java11 59.01% <ø> (+<0.01%) ⬆️
unit-tests-java17 58.72% <ø> (-0.01%) ⬇️
unit-tests-java21 58.70% <ø> (-0.02%) ⬇️
unit-tests-java8 59.01% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw

zrlw commented Aug 22, 2025

Copy link
Copy Markdown
Contributor
  1. all the content should be provided in English.
  2. any pr should be meaningful.

@zrlw zrlw closed this Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants