fix(triple): release REST form request decoder - #16411
Open
014-code wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16411 +/- ##
============================================
+ Coverage 60.79% 60.96% +0.17%
+ Complexity 11777 11765 -12
============================================
Files 1953 1954 +1
Lines 89208 89303 +95
Branches 13458 13476 +18
============================================
+ Hits 54234 54448 +214
+ Misses 29403 29261 -142
- Partials 5571 5594 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
014-code
force-pushed
the
fix/triple-rest-form-decoder-cleanup
branch
from
August 2, 2026 02:40
adef7c4 to
84dfec2
Compare
014-code
force-pushed
the
fix/triple-rest-form-decoder-cleanup
branch
from
August 2, 2026 02:56
84dfec2 to
e506c6c
Compare
LI123456mo
reviewed
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Closes #16403.
Release the cached
HttpPostRequestDecoderwhen a Triple REST request reaches a terminal state. This removes the synthetic request and parsed form data from Netty's staticDefaultHttpDataFactory, preventing retained entries from accumulating after form requests.The cleanup is invoked after successful invocation completion and on error, cancellation, and HTTP/2 transport close paths. It is intentionally not performed immediately after argument decoding so multipart data remains available to application code during request handling.
GitHub_issue
Closes #16403
Tests
Added
completed form request releases post datatoRestProtocolTest.The test submits an
application/x-www-form-urlencodedrequest, verifies the normal response, then asserts thatDefaultHttpDataFactory.requestFileDeleteMaphas no retained request entries.Passed:
RestProtocolTest: 104 tests, 0 failuresverify: passedDefaultHttpRequest.close(): 100% line and branch coverageAbstractServerCallListener.closeRequest(): 100% line coverageChecklist