fix(triple): clean up REST form request decoder - #16412
Open
juzi050 wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16412 +/- ##
============================================
+ Coverage 60.87% 61.04% +0.16%
+ Complexity 11766 11765 -1
============================================
Files 1953 1953
Lines 89273 89304 +31
Branches 13473 13478 +5
============================================
+ Hits 54346 54514 +168
+ Misses 29333 29183 -150
- Partials 5594 5607 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
juzi050
force-pushed
the
fix/triple-rest-post-decoder-cleanup
branch
from
August 1, 2026 19:29
cb5bce3 to
07ba80f
Compare
juzi050
force-pushed
the
fix/triple-rest-post-decoder-cleanup
branch
from
August 2, 2026 10:17
0da1ab2 to
b931dc5
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Closes #16403.
When Triple REST parses an
application/x-www-form-urlencodedormultipart/form-datarequest,DefaultHttpRequestlazily creates and caches anHttpPostRequestDecoder. The decoder was not destroyed after the request completed, soDefaultHttpDataFactorycontinued to retain the request and its form data.This change attaches decoder cleanup to the HTTP response lifecycle:
DefaultHttpRequest.How was it tested?
Extended
HttpPostRequestDecoderLifecycleTestto cover the real Triple REST request path:DefaultHttpDataFactoryafter normal completion.DefaultHttpRequestdo not require decoder cleanup.Added
AbstractServerHttpChannelObserverTestto verify that transport closure defers cleanup until normal application completion and that cleanup runs only once when multiple terminal signals are received. The targeted tests passed.Commands:
The changed files were also formatted with
codestyle/dubbo_codestyle_for_idea.xml. Maven Checkstyle and Spotless checks passed.Checklist