Skip to content

Conversation

@kylixs
Copy link
Member

@kylixs kylixs commented Jan 26, 2021

What is the purpose of the change

Fix error in issue: #7132

Brief changelog

Handle scenario where serviceDiscoveryInvoker is null

Verifying this change

Run tests under dubbo-samples/dubbo-samples-metadata-report/dubbo-samples-metadata-report-local-xml

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@kylixs kylixs changed the title [Dubbo-7132] Handle scenario where serviceDiscoveryInvoker is null [Dubbo-7132] Handle scenario where serviceDiscoveryInvoker is null #7132 Jan 26, 2021
@codecov-io
Copy link

codecov-io commented Jan 26, 2021

Codecov Report

Merging #7133 (3da3f33) into master (27571a0) will decrease coverage by 0.05%.
The diff coverage is 25.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7133      +/-   ##
============================================
- Coverage     60.28%   60.22%   -0.06%     
+ Complexity      510      505       -5     
============================================
  Files          1028     1028              
  Lines         41531    41535       +4     
  Branches       6038     6040       +2     
============================================
- Hits          25037    25016      -21     
- Misses        13750    13764      +14     
- Partials       2744     2755      +11     
Impacted Files Coverage Δ Complexity Δ
...tegration/InterfaceCompatibleRegistryProtocol.java 42.18% <25.00%> (-1.15%) 0.00 <0.00> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 61.36% <0.00%> (-9.10%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-7.96%) 19.00% <0.00%> (-2.00%)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-5.67%) 0.00% <0.00%> (ø%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (-4.35%) 0.00% <0.00%> (ø%)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) 8.00% <0.00%> (-1.00%)
...pache/dubbo/registry/support/AbstractRegistry.java 79.25% <0.00%> (-1.86%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.57% <0.00%> (-0.96%) 16.00% <0.00%> (-1.00%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.00% <0.00%> (-0.59%) 31.00% <0.00%> (ø%)
...figcenter/file/FileSystemDynamicConfiguration.java 62.38% <0.00%> (-0.48%) 0.00% <0.00%> (ø%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27571a0...3da3f33. Read the comment docs.

@chickenlj chickenlj changed the base branch from master to 2.7.9-release February 5, 2021 16:03
@chickenlj
Copy link
Contributor

I've changed the target branch to 2.7.9-release so that we can get it fixed in 2.7.9

@chickenlj chickenlj merged commit 970c475 into apache:2.7.9-release Feb 5, 2021
@kylixs kylixs deleted the fix-migration-invoker-npe branch October 23, 2021 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants