Skip to content

Comments

[3.0] Remove dubbo-all dependency of dubbo-spring-boot#8233

Closed
kylixs wants to merge 1 commit intoapache:3.0from
kylixs:3.0-fix-spring-boot-pom-0706
Closed

[3.0] Remove dubbo-all dependency of dubbo-spring-boot#8233
kylixs wants to merge 1 commit intoapache:3.0from
kylixs:3.0-fix-spring-boot-pom-0706

Conversation

@kylixs
Copy link
Member

@kylixs kylixs commented Jul 6, 2021

What is the purpose of the change

Remove dubbo-all dependency of dubbo-spring-boot

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@kylixs kylixs changed the title Remove dubbo-all dependency of dubbo-spring-boot [3.0] Remove dubbo-all dependency of dubbo-spring-boot Jul 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #8233 (3c51364) into 3.0 (e2d1ec0) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8233      +/-   ##
============================================
- Coverage     63.58%   63.51%   -0.08%     
+ Complexity      313      312       -1     
============================================
  Files          1074     1074              
  Lines         45211    45211              
  Branches       6807     6807              
============================================
- Hits          28749    28714      -35     
- Misses        13272    13301      +29     
- Partials       3190     3196       +6     
Impacted Files Coverage Δ
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 61.36% <0.00%> (-9.10%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 65.21% <0.00%> (-8.70%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 89.65% <0.00%> (-6.90%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0.00%> (-4.55%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 87.17% <0.00%> (-4.28%) ⬇️
...src/main/java/org/apache/dubbo/common/Version.java 66.34% <0.00%> (-2.89%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 78.10% <0.00%> (-2.56%) ⬇️
...etadata/report/support/AbstractMetadataReport.java 60.76% <0.00%> (-0.96%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 80.89% <0.00%> (-0.22%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d1ec0...3c51364. Read the comment docs.

@kylixs kylixs marked this pull request as draft July 9, 2021 03:07
@kylixs
Copy link
Member Author

kylixs commented Jul 9, 2021

The purpose of removing dubbo-all is to reference internal modules when debugging with the IDE, but causes users to use dubbo-spring-boot inconveniently.

@kylixs kylixs closed this Jul 9, 2021
@kylixs kylixs deleted the 3.0-fix-spring-boot-pom-0706 branch October 23, 2021 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants