[MINOR][VL] Re-enable the ignored weekday test in VeloxStringFunctionsSuite - #12688
Open
yikf wants to merge 1 commit into
Open
[MINOR][VL] Re-enable the ignored weekday test in VeloxStringFunctionsSuite#12688yikf wants to merge 1 commit into
yikf wants to merge 1 commit into
Conversation
…sSuite The `weekday` Spark function was fully enabled in apache#4721 (WEEK_DAY -> Velox `weekday`), whose semantics (Monday=0 ... Sunday=6) already match Spark's WeekDay. However, the corresponding test was left as `ignore` with a stale "result mismatched" note that no longer applies. Re-enable it as a regular test, consistent with the adjacent `dayofweek` test.
Contributor
Author
|
@philo-he Could you please take a look, thanks. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables the weekday Spark function test in the Velox backend suite by converting it from an ignored test case back into a regular, executed unit test, aligning it with the already-enabled adjacent date-function tests.
Changes:
- Changed the
weekdaytest fromignore("weekday")totest("weekday")so it runs in CI. - Removed the stale inline note implying result mismatch.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marin-ma
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
The
weekdaySpark function was fully enabled in #4721 (WEEK_DAY -> Veloxweekday), whose semantics (Monday=0 ... Sunday=6) already match Spark's WeekDay.However, the corresponding test was left as
ignorewith a stale "result mismatched" note that no longer applies. Re-enable it as a regular test, consistent with the adjacentdayofweektest.How was this patch tested?
Re-enable the ignored weekday test.
Was this patch authored or co-authored using generative AI tooling?
No.