[VL] Enable weekday & date_from_unix_date Spark functions - #4721
Merged
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
Member
Author
|
@rui-mo, please take a review. Thanks! |
Member
Author
|
Also cc @taiyang-li, as there is a line of change for CH backend. |
rui-mo
approved these changes
Feb 21, 2024
Contributor
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
yikf
added a commit
to yikf/incubator-gluten
that referenced
this pull request
Aug 3, 2026
…sSuite The `weekday` Spark function was fully enabled in apache#4721 (WEEK_DAY -> Velox `weekday`), whose semantics (Monday=0 ... Sunday=6) already match Spark's WeekDay. However, the corresponding test was left as `ignore` with a stale "result mismatched" note that no longer applies. Re-enable it as a regular test, consistent with the adjacent `dayofweek` test. Generated-by: Claude claude-opus-4-8 Co-authored-by: TRAE CLI <noreply@bytedance.com>
yikf
added a commit
to yikf/incubator-gluten
that referenced
this pull request
Aug 3, 2026
…sSuite The `weekday` Spark function was fully enabled in apache#4721 (WEEK_DAY -> Velox `weekday`), whose semantics (Monday=0 ... Sunday=6) already match Spark's WeekDay. However, the corresponding test was left as `ignore` with a stale "result mismatched" note that no longer applies. Re-enable it as a regular test, consistent with the adjacent `dayofweek` test.
yikf
added a commit
to yikf/incubator-gluten
that referenced
this pull request
Aug 3, 2026
…sSuite The `weekday` Spark function was fully enabled in apache#4721 (WEEK_DAY -> Velox `weekday`), whose semantics (Monday=0 ... Sunday=6) already match Spark's WeekDay. However, the corresponding test was left as `ignore` with a stale "result mismatched" note that no longer applies. Re-enable it as a regular test, consistent with the adjacent `dayofweek` test.
yikf
added a commit
to yikf/incubator-gluten
that referenced
this pull request
Aug 3, 2026
…sSuite The `weekday` Spark function was fully enabled in apache#4721 (WEEK_DAY -> Velox `weekday`), whose semantics (Monday=0 ... Sunday=6) already match Spark's WeekDay. However, the corresponding test was left as `ignore` with a stale "result mismatched" note that no longer applies. Re-enable it as a regular test, consistent with the adjacent `dayofweek` test.
yikf
added a commit
to yikf/incubator-gluten
that referenced
this pull request
Aug 4, 2026
…sSuite The `weekday` Spark function was fully enabled in apache#4721 (WEEK_DAY -> Velox `weekday`), whose semantics (Monday=0 ... Sunday=6) already match Spark's WeekDay. However, the corresponding test was left as `ignore` with a stale "result mismatched" note that no longer applies. Re-enable it as a regular test, consistent with the adjacent `dayofweek` test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
These two functions have been supported in Velox recently.
How was this patch tested?
Spark UTs.