Skip to content

Comments

HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc#1196

Merged
virajjasani merged 2 commits intoapache:masterfrom
jojochuang:HBASE-23755
Feb 24, 2020
Merged

HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc#1196
virajjasani merged 2 commits intoapache:masterfrom
jojochuang:HBASE-23755

Conversation

@jojochuang
Copy link
Contributor

Add a NOTE in Appendix L warning that users are advised not to follow the instructions.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 5m 33s master passed
+0 🆗 refguide 4m 45s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 2s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+0 🆗 refguide 4m 48s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Other Tests _
+1 💚 asflicense 0m 20s The patch does not generate ASF License warnings.
22m 8s
Subsystem Report/Notes
Docker Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/1/artifact/out/Dockerfile
GITHUB PR #1196
Optional Tests dupname asflicense refguide
uname Linux a5340aa3a75c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1196/out/precommit/personality/provided.sh
git revision master / 400b7ce
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/1/artifact/out/branch-site/book.html
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/1/artifact/out/patch-site/book.html
Max. process+thread count 96 (vs. ulimit of 10000)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@busbey
Copy link
Contributor

busbey commented Feb 22, 2020

let's delete the section instead? and update the htrace note in the upgrade paths section to note that it's broken?

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 5m 38s master passed
+0 🆗 refguide 4m 52s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 1s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+0 🆗 refguide 4m 45s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Other Tests _
+1 💚 asflicense 0m 20s The patch does not generate ASF License warnings.
22m 8s
Subsystem Report/Notes
Docker Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/2/artifact/out/Dockerfile
GITHUB PR #1196
Optional Tests dupname asflicense refguide
uname Linux 6fcfce720ef5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1196/out/precommit/personality/provided.sh
git revision master / 400b7ce
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/2/artifact/out/branch-site/book.html
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/2/artifact/out/patch-site/book.html
Max. process+thread count 96 (vs. ulimit of 10000)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@virajjasani
Copy link
Contributor

Looks good to you @busbey ?

Copy link
Contributor

@busbey busbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. Should be included on all branches-2.

I haven't been able to see the update in the rendered ref guide from the qabot. Presuming that looks fine to whoever merges I'm good.

@virajjasani
Copy link
Contributor

The change looks good to me. Should be included on all branches-2.

I haven't been able to see the update in the rendered ref guide from the qabot. Presuming that looks fine to whoever merges I'm good.

Roger that. Just realized it, let me trigger one more build

@virajjasani
Copy link
Contributor

virajjasani commented Feb 24, 2020

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 5m 27s master passed
+0 🆗 refguide 4m 47s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 5s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+0 🆗 refguide 4m 46s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Other Tests _
+1 💚 asflicense 0m 19s The patch does not generate ASF License warnings.
21m 53s
Subsystem Report/Notes
Docker Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/3/artifact/out/Dockerfile
GITHUB PR #1196
Optional Tests dupname asflicense refguide
uname Linux 306f9e5a0a56 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1196/out/precommit/personality/provided.sh
git revision master / 4182343
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/3/artifact/out/branch-site/book.html
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/3/artifact/out/patch-site/book.html
Max. process+thread count 75 (vs. ulimit of 10000)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@busbey
Copy link
Contributor

busbey commented Feb 24, 2020

yep that looks great.

@virajjasani virajjasani merged commit 69d683a into apache:master Feb 24, 2020
virajjasani pushed a commit that referenced this pull request Feb 24, 2020
…#1196)

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani pushed a commit that referenced this pull request Feb 24, 2020
…#1196)

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani pushed a commit that referenced this pull request Feb 24, 2020
…#1196)

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani pushed a commit that referenced this pull request Feb 24, 2020
…#1196)

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
…apache#1196)

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
…apache#1196)

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
…apache#1196)

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit 481e9c8)

Change-Id: I1ec34a36f32433008232a13d39bd1fd5b8fcc5db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants