HBASE-23967 Improve the accuracy of the method sizeToString #1273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
reviewed
Mar 11, 2020
Contributor
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
+1 for the change, formatting would make it better
| if (size >= (1L << 20)) return String.format("%dM", size / (1L << 20)); | ||
| if (size >= (1L << 10)) return String.format("%dK", size / (1L << 10)); | ||
| return String.format("%dB", size); | ||
| if (size >= (1L << 50)) return String.format("%.2fP", (double)size / (1L << 50)); |
Contributor
There was a problem hiding this comment.
Please try to provide formatting for every condition i.e.
if (size >= (1L << 50)) {
return String.format("%.2fP", (double)size / (1L << 50));
}
Contributor
Author
There was a problem hiding this comment.
Please try to provide formatting for every condition i.e.
if (size >= (1L << 50)) { return String.format("%.2fP", (double)size / (1L << 50)); }
Formatted, thanks for your review
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
approved these changes
Mar 11, 2020
HorizonNet
approved these changes
Mar 12, 2020
virajjasani
pushed a commit
that referenced
this pull request
Mar 13, 2020
Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
virajjasani
pushed a commit
that referenced
this pull request
Mar 13, 2020
Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
virajjasani
pushed a commit
that referenced
this pull request
Mar 13, 2020
Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
virajjasani
pushed a commit
that referenced
this pull request
Mar 13, 2020
Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
virajjasani
pushed a commit
that referenced
this pull request
Mar 13, 2020
Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
) Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> (cherry picked from commit f17f0aa) Change-Id: I4fdad49a9d6c47d27953dcdb48bd98937affb0ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In QuotaSettings，the method of sizeToString reserved integer. But, this is not very accurate.
hbase(main):001:0> set_quota TYPE => SPACE, TABLE => 't1', LIMIT => '2000G', POLICY => NO_INSERTS hbase(main):002:0> list_quotas OWNER QUOTAS TABLE => t1 TYPE => SPACE, TABLE => t1, LIMIT => 1T, VIOLATION_POLICY => NO_INSERTS 1 row(s) in 0.0340 secondsafter patch：
hbase(main):001:0> set_quota TYPE => SPACE, TABLE => 't1', LIMIT => '2000G', POLICY => NO_INSERTS hbase(main):002:0> list_quotas OWNER QUOTAS TABLE => t1 TYPE => SPACE, TABLE => t1, LIMIT => 1.95T, VIOLATION_POLICY => NO_INSERTS 1 row(s) in 0.0230 seconds