Skip to content

HBASE-24136 Add release branch report to git-jira-release-audit tool#1463

Merged
ndimiduk merged 1 commit intoapache:masterfrom
ndimiduk:24136-git-jira-release-audit-add-release-branch-report
Apr 9, 2020
Merged

HBASE-24136 Add release branch report to git-jira-release-audit tool#1463
ndimiduk merged 1 commit intoapache:masterfrom
ndimiduk:24136-git-jira-release-audit-add-release-branch-report

Conversation

@ndimiduk
Copy link
Member

@ndimiduk ndimiduk commented Apr 8, 2020

  • enhancements to git_jira_release_audit.py
    • add aforementioned release branch report
    • include default values in help doc output
    • swap default db to a file on disk instead of in memory
    • set logger to match file name
    • add separate sql query log at DEBUG level
  • more detailed usage info in README.md, including example audit query
  • update entries in fallback_actions.csv

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 37s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
_ Other Tests _
2m 15s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1463/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1463
Optional Tests
uname Linux 0ea1460f8c74 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / eb7df04
Max. process+thread count 55 (vs. ulimit of 10000)
modules C: U:
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1463/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 17s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
_ Other Tests _
3m 52s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1463/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1463
Optional Tests
uname Linux 927ed4573d49 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / eb7df04
Max. process+thread count 47 (vs. ulimit of 10000)
modules C: U:
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1463/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 17s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
-0 ⚠️ pylint 0m 12s The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
-0 ⚠️ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
_ Other Tests _
+0 🆗 asflicense 0m 0s ASF License check generated no output?
4m 14s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1463/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1463
Optional Tests dupname asflicense pylint markdownlint
uname Linux f20c562b8082 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / eb7df04
pylint https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1463/1/artifact/yetus-general-check/output/diff-patch-pylint.txt
whitespace https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1463/1/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count 47 (vs. ulimit of 10000)
modules C: U:
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1463/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) pylint=2.4.4
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed. LGTM

* enhancements to git_jira_release_audit.py
  * add aforementioned release branch report
  * include default values in help doc output
  * swap default db to a file on disk instead of in memory
  * set logger to match file name
  * add separate sql query log at DEBUG level
* more detailed usage info in README.md, including example audit query
* update entries in fallback_actions.csv

Signed-off-by: stack <stack@apache.org>
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
@ndimiduk ndimiduk force-pushed the 24136-git-jira-release-audit-add-release-branch-report branch from 269457d to 08e23e5 Compare April 9, 2020 16:27
@ndimiduk ndimiduk merged commit b4af0a0 into apache:master Apr 9, 2020
@ndimiduk
Copy link
Member Author

ndimiduk commented Apr 9, 2020

Thanks folks.

@ndimiduk ndimiduk deleted the 24136-git-jira-release-audit-add-release-branch-report branch April 9, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants