HBASE-23933 Separate a hbase-balancer module

[nyl3532016]

No description provided.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 2s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 43s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 13s	master passed
+1 💚	checkstyle	2m 27s	master passed
+1 💚	spotbugs	12m 37s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 0s	the patch passed
-0 ⚠️	checkstyle	2m 25s	root: The patch generated 19 new + 377 unchanged - 13 fixed = 396 total (was 390)
-0 ⚠️	whitespace	0m 0s	The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	xml	0m 9s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	10m 28s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚	spotbugs	14m 2s	the patch passed
		_ Other Tests _
-1 ❌	asflicense	0m 56s	The patch generated 1 ASF License warnings.
		62m 38s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1501
Optional Tests	dupname asflicense hadoopcheck xml spotbugs hbaseanti checkstyle
uname	Linux 81a623ffaa52 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 22675d8
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespace	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/artifact/yetus-general-check/output/whitespace-eol.txt
asflicense	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count	93 (vs. ulimit of 10000)
modules	C: hbase-server hbase-balancer . hbase-assembly U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 43s	Maven dependency ordering for branch
+1 💚	mvninstall	7m 11s	master passed
+1 💚	compile	4m 24s	master passed
+1 💚	shadedjars	6m 30s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 20s	root in master failed.
-0 ⚠️	javadoc	0m 41s	hbase-server in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 42s	the patch passed
+1 💚	compile	4m 5s	the patch passed
+1 💚	javac	4m 5s	the patch passed
-1 ❌	shadedjars	4m 37s	patch has 10 errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 40s	hbase-server in the patch failed.
-0 ⚠️	javadoc	0m 15s	hbase-balancer in the patch failed.
-0 ⚠️	javadoc	0m 18s	root in the patch failed.
		_ Other Tests _
-1 ❌	unit	184m 49s	root in the patch failed.
		224m 58s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1501
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 23a881a2cca2 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 22675d8
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-balancer.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/testReport/
Max. process+thread count	3388 (vs. ulimit of 10000)
modules	C: hbase-server hbase-balancer . hbase-assembly U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 59s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 41s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 18s	master passed
+1 💚	compile	3m 43s	master passed
+1 💚	shadedjars	5m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 9s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 19s	the patch passed
+1 💚	compile	3m 18s	the patch passed
+1 💚	javac	3m 18s	the patch passed
-1 ❌	shadedjars	3m 56s	patch has 10 errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 35s	hbase-server generated 8 new + 0 unchanged - 0 fixed = 8 total (was 0)
-0 ⚠️	javadoc	2m 39s	root generated 6 new + 87 unchanged - 0 fixed = 93 total (was 87)
		_ Other Tests _
-1 ❌	unit	188m 33s	root in the patch failed.
		230m 35s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1501
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 352db72b77dd 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 22675d8
Default Java	1.8.0_232
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-root.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/testReport/
Max. process+thread count	3233 (vs. ulimit of 10000)
modules	C: hbase-server hbase-balancer . hbase-assembly U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 2s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 29s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 13s	master passed
+1 💚	checkstyle	2m 7s	master passed
+1 💚	spotbugs	10m 5s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 11s	the patch passed
-0 ⚠️	checkstyle	2m 7s	root: The patch generated 13 new + 308 unchanged - 12 fixed = 321 total (was 320)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 9s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	10m 49s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
-1 ❌	spotbugs	2m 7s	hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
-1 ❌	spotbugs	8m 31s	root generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 52s	The patch does not generate ASF License warnings.
		53m 6s

Reason	Tests
FindBugs	module:hbase-server
	Unread field:BaseLoadBalancer.java:[line 161]
	Unread field:BaseLoadBalancer.java:[line 276]
FindBugs	module:root
	Unread field:BaseLoadBalancer.java:[line 161]
	Unread field:BaseLoadBalancer.java:[line 276]

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1501
Optional Tests	dupname asflicense hadoopcheck xml spotbugs hbaseanti checkstyle
uname	Linux cb6d15d612bf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 35ea4ac
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt
spotbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
spotbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/artifact/yetus-general-check/output/new-spotbugs-root.html
Max. process+thread count	137 (vs. ulimit of 12500)
modules	C: hbase-server hbase-balancer hbase-assembly . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 45s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 3s	master passed
+1 💚	compile	2m 40s	master passed
+1 💚	shadedjars	5m 25s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 19s	root in master failed.
-0 ⚠️	javadoc	0m 38s	hbase-server in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 52s	the patch passed
+1 💚	compile	2m 41s	the patch passed
+1 💚	javac	2m 41s	the patch passed
+1 💚	shadedjars	5m 22s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 38s	hbase-server in the patch failed.
-0 ⚠️	javadoc	0m 16s	hbase-balancer in the patch failed.
-0 ⚠️	javadoc	0m 17s	root in the patch failed.
		_ Other Tests _
-1 ❌	unit	124m 29s	root in the patch failed.
		156m 52s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1501
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b5228d70bbf4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 35ea4ac
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-balancer.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/testReport/
Max. process+thread count	4433 (vs. ulimit of 12500)
modules	C: hbase-server hbase-balancer . hbase-assembly U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 47s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 8s	master passed
+1 💚	compile	2m 45s	master passed
+1 💚	shadedjars	5m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 44s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 59s	the patch passed
+1 💚	compile	2m 37s	the patch passed
+1 💚	javac	2m 37s	the patch passed
+1 💚	shadedjars	6m 11s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 45s	hbase-server generated 9 new + 0 unchanged - 0 fixed = 9 total (was 0)
-0 ⚠️	javadoc	2m 46s	root generated 6 new + 87 unchanged - 0 fixed = 93 total (was 87)
		_ Other Tests _
-1 ❌	unit	191m 2s	root in the patch failed.
		228m 34s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1501
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 14a03757dce8 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 35ea4ac
Default Java	1.8.0_232
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-root.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/testReport/
Max. process+thread count	2591 (vs. ulimit of 12500)
modules	C: hbase-server hbase-balancer . hbase-assembly U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 48s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 5s	master passed
+1 💚	compile	2m 32s	master passed
+1 💚	shadedjars	5m 54s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 33s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 44s	the patch passed
+1 💚	compile	2m 37s	the patch passed
+1 💚	javac	2m 37s	the patch passed
+1 💚	shadedjars	5m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 49s	the patch passed
		_ Other Tests _
-1 ❌	unit	10m 55s	root in the patch failed.
		47m 24s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1501
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0335f95898c5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 38954ed
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/testReport/
Max. process+thread count	649 (vs. ulimit of 12500)
modules	C: hbase-common hbase-server hbase-balancer . hbase-assembly U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 2s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 45s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 41s	master passed
+1 💚	checkstyle	2m 15s	master passed
+1 💚	spotbugs	11m 37s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 11s	the patch passed
-0 ⚠️	checkstyle	2m 5s	root: The patch generated 255 new + 315 unchanged - 262 fixed = 570 total (was 577)
+1 💚	whitespace	0m 1s	The patch has no whitespace issues.
+1 💚	xml	0m 9s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	11m 0s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚	spotbugs	12m 53s	the patch passed
		_ Other Tests _
+1 💚	asflicense	1m 6s	The patch does not generate ASF License warnings.
		57m 50s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1501
Optional Tests	dupname asflicense hadoopcheck xml spotbugs hbaseanti checkstyle
uname	Linux 10117b3e3d35 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 38954ed
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt
Max. process+thread count	137 (vs. ulimit of 12500)
modules	C: hbase-common hbase-server hbase-balancer . hbase-assembly U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 40s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 32s	master passed
+1 💚	compile	3m 0s	master passed
+1 💚	shadedjars	6m 5s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 16s	hbase-common in master failed.
-0 ⚠️	javadoc	0m 16s	root in master failed.
-0 ⚠️	javadoc	0m 39s	hbase-server in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 20s	the patch passed
+1 💚	compile	2m 59s	the patch passed
+1 💚	javac	2m 59s	the patch passed
+1 💚	shadedjars	5m 58s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 16s	hbase-common in the patch failed.
-0 ⚠️	javadoc	0m 40s	hbase-server in the patch failed.
-0 ⚠️	javadoc	0m 16s	hbase-balancer in the patch failed.
-0 ⚠️	javadoc	0m 16s	root in the patch failed.
		_ Other Tests _
-1 ❌	unit	233m 41s	root in the patch failed.
		268m 8s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1501
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d4bcdb188cd0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 38954ed
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-balancer.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/testReport/
Max. process+thread count	2963 (vs. ulimit of 12500)
modules	C: hbase-common hbase-server hbase-balancer . hbase-assembly U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 45s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 25s	master passed
+1 💚	checkstyle	2m 18s	master passed
+0 🆗	refguide	4m 50s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	10m 42s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 12s	the patch passed
-0 ⚠️	checkstyle	2m 16s	root: The patch generated 321 new + 435 unchanged - 327 fixed = 756 total (was 762)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 9s	The patch has no ill-formed XML file.
+0 🆗	refguide	4m 41s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	10m 50s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚	spotbugs	12m 11s	the patch passed
		_ Other Tests _
+1 💚	asflicense	1m 8s	The patch does not generate ASF License warnings.
		65m 27s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1501
Optional Tests	dupname asflicense hadoopcheck xml spotbugs hbaseanti checkstyle refguide
uname	Linux 17a7eaab80db 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 38954ed
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/artifact/yetus-general-check/output/branch-site/book.html
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count	137 (vs. ulimit of 12500)
modules	C: hbase-common hbase-server hbase-balancer . hbase-assembly U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 44s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 57s	master passed
+1 💚	compile	2m 30s	master passed
+1 💚	shadedjars	5m 18s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 27s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 46s	the patch passed
+1 💚	compile	2m 31s	the patch passed
+1 💚	javac	2m 31s	the patch passed
+1 💚	shadedjars	5m 12s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	264m 48s	root in the patch passed.
		301m 4s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1501
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c822a045c357 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 38954ed
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/testReport/
Max. process+thread count	4552 (vs. ulimit of 12500)
modules	C: hbase-common hbase-server hbase-balancer . hbase-assembly U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 46s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 51s	master passed
+1 💚	compile	3m 8s	master passed
+1 💚	shadedjars	6m 29s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 19s	hbase-common in master failed.
-0 ⚠️	javadoc	0m 21s	root in master failed.
-0 ⚠️	javadoc	0m 43s	hbase-server in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 38s	the patch passed
+1 💚	compile	3m 9s	the patch passed
+1 💚	javac	3m 9s	the patch passed
+1 💚	shadedjars	6m 21s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 18s	hbase-common in the patch failed.
-0 ⚠️	javadoc	0m 53s	hbase-server in the patch failed.
-0 ⚠️	javadoc	0m 18s	hbase-balancer in the patch failed.
-0 ⚠️	javadoc	0m 16s	root in the patch failed.
		_ Other Tests _
+1 💚	unit	264m 12s	root in the patch passed.
		302m 35s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1501
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9512827b78bd 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 38954ed
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-balancer.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/testReport/
Max. process+thread count	4634 (vs. ulimit of 12500)
modules	C: hbase-common hbase-server hbase-balancer . hbase-assembly U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1501/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache9]

Oh, this is a big change, hard to review so let me ask some questions.

I think balancer is somehow tied with some components of HMaster, such as ServerManager and AssignmentManager? How do you break the tie?

Thanks.

[nyl3532016]

Oh, this is a big change, hard to review so let me ask some questions.

I think balancer is somehow tied with some components of HMaster, such as ServerManager and AssignmentManager? How do you break the tie?

Thanks.

I do not break the tie, so the module hbase-balancer depends on hbase-server ,not on the contrary.
LoadBalancer is a interface,so we can separate all it's implement and ut into hbase-balancer module, just leave LoadBalancerFactory in module hbase-server for balancer class instantiation.
Some key points of actual separation:
1.Leave RSGroupBasedLoadBalancer in hbase-server module, for we must use rsgroup now
2.Newly add a class MiniHBaseLoadBalancer and set as default in MiniHBaseCluster, so the minicluster can start up without dependency of hbase-balancer
3.Leave BaseLoadBalancer in hbase-server module, for assignment correctness to pass some ut, these ut not related balance but assignment
4.we do not change default loadbalancer StochasticLoadBalancer, and in production environment,we must depend on module hbase-balancer

[Apache9]

Oh, the reverse way...

I do not think this is a good idea...

In general, we need hbase-balancer when running the hbase-server, so make hbase-balancer depend on hbase-server is a bit strange and easy to confuse others...

[nyl3532016]

Oh, the reverse way...

I do not think this is a good idea...

In general, we need hbase-balancer when running the hbase-server, so make hbase-balancer depend on hbase-server is a bit strange and easy to confuse others...

How about rename module hbase-server to hbase-core/hbase-server-core , and add a new hbase-server module that depends on hbase-core , hbase-balancer... etc. Code in the new hbase-server module only contain ut that need start up minicluster, it seems no change to users. And we can separate the hbase-core gradually to each independent module