HBASE-24200 Upgrade to Yetus 0.12.0 by ndimiduk · Pull Request #1531 · apache/hbase

ndimiduk · 2020-04-16T16:26:49Z

No description provided.

dev-support/Jenkinsfile_GitHub

Apache9 · 2020-10-06T12:21:51Z

I tried on HBASE-25152, we just need to change the version number. Let's finish this issue?

ndimiduk · 2020-10-09T16:39:56Z

@busbey @Apache9 @saintstack this look right you you?

Maybe after this we can revert back to using Yetus's multijdk feature and getting just a single comment posted.

Apache9

We also use yetus in nightly builds, so let's also upgrade the dev-support/Jenkinsfile?

What about the yetus in release scripts? I'm not sure what it is used for...

Apache9 · 2020-10-10T00:18:51Z

pom.xml

Remove this line?

Yes, this line would not be merged. It's here to provoke a test run; without it, Yetus won't run over any maven modules.

saintstack · 2020-10-10T00:23:29Z

What about the yetus in release scripts? I'm not sure what it is used for...

It is used to generate CHANGES.md and RELEASENOTES.md Curls it down.

ndimiduk · 2020-10-12T20:38:01Z

Rebased. Grepped the source tree for 0\.11 and found a couple more occurrences. We should delete jenkins_precommit_jira_yetus.sh since we don't do builds from Jira tickets anymore.

pom.xml

Apache-HBase · 2020-10-21T19:44:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 19s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	hadolint	0m 1s	There were no new hadolint issues.
+1 💚	shellcheck	0m 1s	There were no new shellcheck issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	19m 29s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		28m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1531
Optional Tests	dupname asflicense shellcheck shelldocs hadolint hadoopcheck xml
uname	Linux c6891950f987 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2cd5f91`
Max. process+thread count	63 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/8/console
versions	git=2.17.1 maven=3.6.3 shellcheck=0.4.6 hadolint=1.17.5-0-g443423c
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2020-10-21T20:58:04Z

Removed change to audience-annotations.version in pom.xml

Apache-HBase · 2020-10-22T00:12:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 2s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 15s	master passed
+1 💚	compile	3m 22s	master passed
+1 💚	shadedjars	7m 48s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 17s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 33s	the patch passed
+1 💚	compile	3m 9s	the patch passed
+1 💚	javac	3m 9s	the patch passed
+1 💚	shadedjars	7m 31s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 40s	the patch passed
		_ Other Tests _
+1 💚	unit	252m 32s	root in the patch passed.
		296m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1531
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6f9e2e3557da 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2cd5f91`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/8/testReport/
Max. process+thread count	4932 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/8/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

Please remove the modification in pom.xml before merging.

Thanks.

Apache-HBase · 2020-10-22T02:43:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	hadolint	0m 1s	There were no new hadolint issues.
+1 💚	shellcheck	0m 1s	There were no new shellcheck issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	18m 42s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		27m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1531
Optional Tests	dupname asflicense shellcheck shelldocs hadolint hadoopcheck xml
uname	Linux 151735863b28 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2cd5f91`
Max. process+thread count	63 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/9/console
versions	git=2.17.1 maven=3.6.3 shellcheck=0.4.6 hadolint=1.17.5-0-g443423c
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-10-22T07:04:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 48s	master passed
+1 💚	compile	3m 8s	master passed
+1 💚	shadedjars	7m 24s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 4s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 33s	the patch passed
+1 💚	compile	3m 18s	the patch passed
+1 💚	javac	3m 18s	the patch passed
+1 💚	shadedjars	7m 34s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	247m 26s	root in the patch passed.
		287m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1531
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2f5b8e7cf4b5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2cd5f91`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/9/testReport/
Max. process+thread count	4460 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/9/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-10-22T07:52:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 43s	master passed
+1 💚	compile	2m 20s	master passed
+1 💚	shadedjars	6m 34s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 7s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 27s	the patch passed
+1 💚	compile	2m 16s	the patch passed
+1 💚	javac	2m 16s	the patch passed
+1 💚	shadedjars	6m 29s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 0s	the patch passed
		_ Other Tests _
-1 ❌	unit	303m 20s	root in the patch failed.
		335m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/9/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1531
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6ca5a2d12eb3 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2cd5f91`
Default Java	AdoptOpenJDK-1.8.0_232-b09
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/9/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/9/testReport/
Max. process+thread count	4495 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/9/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Sean Busbey <busbey@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>

Apache-HBase · 2020-10-29T22:38:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 32s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
		_ Other Tests _
		2m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/10/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1531
Optional Tests
uname	Linux bd4a2e3fc72d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `12d0397`
Max. process+thread count	48 (vs. ulimit of 30000)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/10/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-10-29T22:39:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 29s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	hadolint	0m 2s	There were no new hadolint issues.
+1 💚	shellcheck	0m 1s	There were no new shellcheck issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+0 🆗	asflicense	0m 0s	ASF License check generated no output?
		2m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/10/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1531
Optional Tests	dupname asflicense shellcheck shelldocs hadolint
uname	Linux dfbffb697788 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `12d0397`
Max. process+thread count	45 (vs. ulimit of 30000)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/10/console
versions	git=2.17.1 maven=3.6.3 shellcheck=0.4.6 hadolint=1.17.5-0-g443423c
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-10-29T22:40:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 7s	Maven dependency ordering for patch
		_ Other Tests _
		3m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/10/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1531
Optional Tests
uname	Linux 2519054153ea 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `12d0397`
Max. process+thread count	52 (vs. ulimit of 30000)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1531/10/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2020-10-29T22:46:07Z

Landed to master. Will watch this one. Meanwhile, staging PRs for the other active branches.

This comment has been minimized.

Sign in to view

saintstack reviewed Apr 29, 2020

View reviewed changes

dev-support/Jenkinsfile_GitHub Outdated Show resolved Hide resolved

saintstack mentioned this pull request Oct 6, 2020

test yetus 0.12.0 #2499

Closed

ndimiduk force-pushed the 24200-yetus-0.12.0 branch 2 times, most recently from 3515e97 to 08fbdbc Compare October 9, 2020 00:20

This comment has been minimized.

Sign in to view

ndimiduk requested review from Apache9, busbey and saintstack October 9, 2020 16:38

Apache9 requested changes Oct 10, 2020

View reviewed changes

ndimiduk force-pushed the 24200-yetus-0.12.0 branch from 08fbdbc to ca19052 Compare October 12, 2020 20:36

This comment has been minimized.

Sign in to view

ndimiduk force-pushed the 24200-yetus-0.12.0 branch from ca19052 to 488c823 Compare October 21, 2020 19:15

busbey reviewed Oct 21, 2020

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

ndimiduk marked this pull request as ready for review October 21, 2020 20:56

ndimiduk force-pushed the 24200-yetus-0.12.0 branch from 488c823 to 1c9e3a3 Compare October 21, 2020 20:57

Apache9 approved these changes Oct 22, 2020

View reviewed changes

busbey approved these changes Oct 22, 2020

View reviewed changes

HBASE-24200 Upgrade to Yetus 0.12.0

19e7f7b

Signed-off-by: Sean Busbey <busbey@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>

ndimiduk force-pushed the 24200-yetus-0.12.0 branch from 1c9e3a3 to 19e7f7b Compare October 29, 2020 22:35

ndimiduk merged commit eee1cf7 into apache:master Oct 29, 2020

ndimiduk deleted the 24200-yetus-0.12.0 branch October 29, 2020 22:45

Conversation

ndimiduk commented Apr 16, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Apache9 commented Oct 6, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ndimiduk commented Oct 9, 2020

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Apache9 Oct 10, 2020

Choose a reason for hiding this comment

Uh oh!

ndimiduk Oct 12, 2020

Choose a reason for hiding this comment

Uh oh!

saintstack commented Oct 10, 2020

Uh oh!

ndimiduk commented Oct 12, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Apache-HBase commented Oct 21, 2020

Uh oh!

ndimiduk commented Oct 21, 2020

Uh oh!

Apache-HBase commented Oct 22, 2020

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Oct 22, 2020

Uh oh!

Apache-HBase commented Oct 22, 2020

Uh oh!

Apache-HBase commented Oct 22, 2020

Uh oh!

Apache-HBase commented Oct 29, 2020

Uh oh!

Apache-HBase commented Oct 29, 2020

Uh oh!

Apache-HBase commented Oct 29, 2020

Uh oh!

ndimiduk commented Oct 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments