[HBASE-24190] Make kerberos value of hbase.security.authentication property case insensitive#1687
Merged
virajjasani merged 2 commits intoapache:masterfrom May 11, 2020
Merged
Conversation
…operty case insensitive
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
@shahrs87 planning to write a test case? would be good to cover the case insensitivity. |
Contributor
Author
|
@virajjasani Thank you for the review. I added a test case as you asked. There is one problem. It is not testing the changes that I made in this PR because there is no one central point and one conf property (SyncTable uses both hadoop.security.authentication and hbase.security.authentication) where it checks where hbase.security.authentication is equal to keberos. Let me know what you think ? |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
pushed a commit
that referenced
this pull request
May 11, 2020
…sensitive (#1687) Signed-off-by: binlijin <binlijin@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani
pushed a commit
that referenced
this pull request
May 11, 2020
…sensitive (#1687) Signed-off-by: binlijin <binlijin@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani
pushed a commit
that referenced
this pull request
May 11, 2020
…sensitive (#1687) Signed-off-by: binlijin <binlijin@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani
pushed a commit
that referenced
this pull request
May 11, 2020
…sensitive (#1687) Signed-off-by: binlijin <binlijin@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani
pushed a commit
that referenced
this pull request
May 11, 2020
…operty case insensitive (#1687) Signed-off-by: binlijin <binlijin@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani
pushed a commit
that referenced
this pull request
May 11, 2020
…operty case insensitive (#1687) Signed-off-by: binlijin <binlijin@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
Contributor
Author
|
Thank you @virajjasani @binlijin for the review and commit. |
Member
|
Hey guys, the commit for this issue does not include the JIRA id in the subject. The commit needs reverted, the subject fixed, and reapplied everywhere. |
Member
|
Also, the JIRA summary and the commit subject should match. they do not. |
Contributor
Author
@ndimiduk The commit message does contain jira id. Below is the commit message.
I changed the jira title to be the same as commit message. |
Member
|
Perhaps it's some branches and not others? Sorry for not being more precise, @shahrs87 . I've been monitoring branch-2.3 and found I'm accustomed to a process whereby an issue is committed to one branch and then that commit is applied to other applicable branches. If we're seeing that there's a correct commit on one some branches and not others, then it seems the committer needs a little more diligence in their backport process. Thanks for fixing up the Jira summary. Having uniformity between Jira and git makes it easier for release managers to audit for consistency between the two systems. |
Contributor
Author
@ndimiduk I see. This makes perfect sense. @virajjasani Could you please help here ?
Thank you pointing it out. Will take care in future. :) |
Contributor
|
This is weird. I merged the PR and cherry-picked it to others and now only master has Jira id, others don't. The patch has this subject: Wondering if commit message not having Jira id has anything to do with surrounding square bracket. |
virajjasani
pushed a commit
that referenced
this pull request
May 14, 2020
…operty case insensitive (#1687) Signed-off-by: binlijin <binlijin@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani
pushed a commit
that referenced
this pull request
May 14, 2020
…operty case insensitive (#1687) Signed-off-by: binlijin <binlijin@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani
pushed a commit
that referenced
this pull request
May 14, 2020
…operty case insensitive (#1687) Signed-off-by: binlijin <binlijin@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani
pushed a commit
that referenced
this pull request
May 14, 2020
…operty case insensitive (#1687) Signed-off-by: binlijin <binlijin@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
Contributor
Author
|
Thank you @virajjasani ! |
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
May 24, 2021
…sensitive (apache#1687) Signed-off-by: binlijin <binlijin@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 057d83c) Change-Id: I29b242517e839c47075bfb20699d34f55f7001ac
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
May 24, 2021
… case insensitive (apache#1687)" This reverts commit 057d83c. (cherry picked from commit 87ce2cf) Change-Id: I3a2605648c93886b3071f9a24b960ce4294eb6fa
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
May 24, 2021
…operty case insensitive (apache#1687) Signed-off-by: binlijin <binlijin@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 1ea35aa) Change-Id: I4655808950934592b2d5091c8fb4c0ebdff0ea0c
udaynpusa
pushed a commit
to mapr/hbase
that referenced
this pull request
Jan 30, 2024
…operty case insensitive (apache#1687) Signed-off-by: binlijin <binlijin@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.