HBASE-24296 install yetus as a part of building the rm docker image.#1726
Closed
busbey wants to merge 2 commits intoapache:masterfrom
Closed
HBASE-24296 install yetus as a part of building the rm docker image.#1726busbey wants to merge 2 commits intoapache:masterfrom
busbey wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
mind taking a look @mattf-apache ? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Member
mattf-apache
left a comment
mattf-apache
left a comment
There was a problem hiding this comment.
Thanks for the opportunity to comment, @busbey
* non-zero exit for usage * in non-docker mode prompt for yetus install location * make sure we exit if YETUS_HOME does not actually point at a yetus install.
Contributor
Author
|
Thanks for the review @mattf-apache |
ndimiduk
approved these changes
May 20, 2020
|
|
||
| if should_build "tag" && [ "$SKIP_TAG" = 0 ]; then | ||
| if [ -z "${YETUS_HOME}" ] && [ "${RUNNING_IN_DOCKER}" != "1" ]; then | ||
| declare local_yetus="/opt/apache-yetus/0.11.1/" |
Member
There was a problem hiding this comment.
nit: you can use the symlink provided at /usr/local/opt/yetus to get whatever yetus version the user already has installed.
Member
There was a problem hiding this comment.
Oh, you're intentionally pinning the Yetus version. Too bad you can't use YETUS_VERSION here...
saintstack
approved these changes
May 20, 2020
Contributor
saintstack
left a comment
saintstack
left a comment
There was a problem hiding this comment.
Looks viable to me. If works for you, +1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.