HBASE-23941 : FilterBy operator support in get_slowlog_responses API#1793
Merged
virajjasani merged 2 commits intoapache:masterfrom May 30, 2020
Merged
HBASE-23941 : FilterBy operator support in get_slowlog_responses API#1793virajjasani merged 2 commits intoapache:masterfrom
virajjasani merged 2 commits intoapache:masterfrom
Conversation
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
bharathv
requested changes
May 29, 2020
Contributor
bharathv
left a comment
bharathv
left a comment
There was a problem hiding this comment.
Try to make the make it a little concise, otherwise looks fine.
| AdminProtos.SlowLogResponseRequest request, | ||
| List<TooSlowLog.SlowLogPayload> slowLogPayloadList) { | ||
| List<TooSlowLog.SlowLogPayload> filteredSlowLogPayloads = new ArrayList<>(); | ||
| int totalFilters = getTotalFiltersCount(request); |
Contributor
There was a problem hiding this comment.
if (filterCount == 0) {
return ...
}
| int totalFilters = getTotalFiltersCount(request); | ||
| for (TooSlowLog.SlowLogPayload slowLogPayload : slowLogPayloadList) { | ||
| int totalFilterMatches = 0; | ||
| if (StringUtils.isNotEmpty(request.getRegionName())) { |
Contributor
There was a problem hiding this comment.
Apply only the filters that are actually in the request, why check if a filter exists in every iteration?
|
|
||
| static List<TooSlowLog.SlowLogPayload> getFilteredLogs( | ||
| AdminProtos.SlowLogResponseRequest request, List<TooSlowLog.SlowLogPayload> logPayloadList) { | ||
| if (isFilterProvided(request)) { |
Contributor
There was a problem hiding this comment.
no need for this if you implement the above logic I suggested..
| return logPayloadList.subList(0, limit); | ||
| } | ||
|
|
||
| private static boolean isFilterProvided(AdminProtos.SlowLogResponseRequest request) { |
Contributor
There was a problem hiding this comment.
and you can remove this..
|
🎊 +1 overall
This message was automatically generated. |
ndimiduk
approved these changes
May 29, 2020
Member
ndimiduk
left a comment
ndimiduk
left a comment
There was a problem hiding this comment.
This change looks good to me.
Reading through your examples, I realize it would have been nice if we supported filter operations other than equality. String prefix and regex come to mind, for matching tables, say, by namespace, or regions by rowkey range. Another idea is CIDR matching of client IP addresses by subnet.
|
💔 -1 overall
This message was automatically generated. |
bharathv
approved these changes
May 29, 2020
Contributor
bharathv
left a comment
bharathv
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround, lgtm.
Contributor
Author
That's quite interesting idea 👍 |
virajjasani
added a commit
that referenced
this pull request
May 30, 2020
…1793) Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
virajjasani
added a commit
that referenced
this pull request
May 30, 2020
…1793) Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
…pache#1793) Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.