HBASE-20904 Prometheus /metrics http endpoint for monitoring by mmpataki · Pull Request #1814 · apache/hbase

mmpataki · 2020-05-30T16:54:20Z

Since all the metricsources have not moved to new metrics API, I added two servlets.

a. /prom (PrometheusServlet) uses the hbase native metrics API.
b. /prom-old (PrometheusHadoop2Servlet) uses the hadoop2 metrics API

PrometheusHadoop2Servlet can be thrown out once all the metricsources start using the hbase native metrics collection API.

Side note

Most of the servlet code for /prom-old code is cloned from HADOOP-16398

busbey · 2020-05-30T17:06:12Z

Hi! Can you comment on the jira issue so I can assign it to you?

mmpataki · 2020-05-30T17:14:22Z

@busbey I have commented on it.

mmpataki · 2020-05-30T17:41:28Z

@busbey I am not understanding this Apache pre-commit builds, why the build fails in first and succeeds in second attempt

saintstack · 2020-05-31T04:26:36Z

@mmpataki We have flakey tests.

saintstack

Looks good but we export protmetheus metrics even when they are not of use, not being accessed?

mmpataki · 2020-05-31T04:41:41Z

@saintstack

@mmpataki We have flakey tests.

I am sorry, I ran tests from the IDE and not from mvn, so this build issue came up.

Looks good but we export protmetheus metrics even when they are not of use, not being accessed?

thank you for the review, I will add a configuration to enable it (disabled by default).
// I asked about this in mailing list but didn't get any responses.

mmpataki · 2020-05-31T05:50:25Z

added a missing update to hbase-default.xml

mmpataki · 2020-05-31T09:43:20Z

Updated the conf key name in HttpServer.java

Apache-HBase · 2020-06-23T12:18:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 32s	master passed
+1 💚	checkstyle	1m 56s	master passed
+0 🆗	refguide	4m 53s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	10m 11s	master passed
-0 ⚠️	patch	1m 2s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 21s	the patch passed
-0 ⚠️	checkstyle	1m 55s	root: The patch generated 32 new + 7 unchanged - 0 fixed = 39 total (was 7)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+0 🆗	refguide	4m 58s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	11m 8s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	10m 59s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 53s	The patch does not generate ASF License warnings.
		62m 42s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1814
Optional Tests	dupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 76cbe7b7b78d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `500a1df`
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-general-check/output/branch-site/book.html
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-general-check/output/diff-checkstyle-root.txt
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count	137 (vs. ulimit of 12500)
modules	C: hbase-common hbase-hadoop-compat hbase-http . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

mmpataki · 2020-06-23T14:39:39Z

hbase-http/src/main/java/org/apache/hadoop/hbase/http/prometheus/PrometheusHadoop2Servlet.java

+    } else {
+      synchronized (waitingRoom) {
+        try {
+          waitingRoom.wait(5000L);


It's not worth waiting for more than X seconds to get the metrics. (X should be 1s) if we can't produce in 1s we should/can return the metrics which were produced by earlier producer. (1s old metrics are acceptable?)

It's guaranteed that the old metrics will be there when we come out of this wait.

Once the thread comes out of wait, it tries to get back the lock which is unnecessary is there way to avoid it?

mmpataki · 2020-06-23T15:29:48Z

@busbey @saintstack I am blocked because of this (HADOOP-17081) issue I reported today (I will fix it) and for now, trying to implement a hack, any suggestions are welcome.
....

I solved this by adding a Helper class in to hadoop-metrics2 package (in hadoop compat project)

Apache-HBase · 2020-06-23T15:43:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 23s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 43s	master passed
+1 💚	compile	3m 2s	master passed
+1 💚	shadedjars	6m 21s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 15s	root in master failed.
-0 ⚠️	javadoc	0m 16s	hbase-common in master failed.
-0 ⚠️	javadoc	0m 17s	hbase-hadoop-compat in master failed.
-0 ⚠️	javadoc	0m 15s	hbase-http in master failed.
-0 ⚠️	patch	7m 57s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 26s	the patch passed
+1 💚	compile	3m 1s	the patch passed
+1 💚	javac	3m 1s	the patch passed
+1 💚	shadedjars	6m 18s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 15s	hbase-common in the patch failed.
-0 ⚠️	javadoc	0m 18s	hbase-hadoop-compat in the patch failed.
-0 ⚠️	javadoc	0m 16s	hbase-http in the patch failed.
-0 ⚠️	javadoc	0m 14s	root in the patch failed.
		_ Other Tests _
+1 💚	unit	232m 57s	root in the patch passed.
		267m 11s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1814
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9ce324749646 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `500a1df`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/testReport/
Max. process+thread count	4765 (vs. ulimit of 12500)
modules	C: hbase-common hbase-hadoop-compat hbase-http . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-23T17:08:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 34s	master passed
+1 💚	compile	2m 19s	master passed
+1 💚	shadedjars	5m 30s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 51s	master passed
-0 ⚠️	patch	8m 54s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 23s	the patch passed
+1 💚	compile	2m 21s	the patch passed
+1 💚	javac	2m 21s	the patch passed
+1 💚	shadedjars	5m 28s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 49s	the patch passed
		_ Other Tests _
-1 ❌	unit	320m 8s	root in the patch failed.
		352m 13s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1814
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ead9d112ce8b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `500a1df`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/testReport/
Max. process+thread count	5744 (vs. ulimit of 12500)
modules	C: hbase-common hbase-hadoop-compat hbase-http . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

busbey · 2020-06-25T05:18:48Z

Is it worth to write a exporter for hadoop2 metrics when it's decided to use the native metrics system? I have mixed answers, please comment on this.

This same question popped into my head. 😸 glad you found a work around, but I think a good argument could be made for just doing the native metrics. that said, I don't have the cycles right now to do a metrics review to make sure we have a good set to start with.

busbey · 2020-06-25T05:19:48Z

a glance shows the unit test failures are all in the backup/restore system? is that right?

mmpataki · 2020-06-25T16:15:22Z

a glance shows the unit test failures are all in the backup/restore system? is that right?

Yes, the test failures don't seem to be related. I will try to check them tomorrow.

mmpataki · 2020-06-28T13:10:06Z

a glance shows the unit test failures are all in the backup/restore system? is that right?

Yes the failures are in backup-restore component.

Apache-HBase · 2020-07-05T06:48:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 25s	master passed
+1 💚	checkstyle	1m 57s	master passed
+0 🆗	refguide	4m 58s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	10m 9s	master passed
-0 ⚠️	patch	9m 1s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 23s	the patch passed
-0 ⚠️	checkstyle	1m 55s	root: The patch generated 29 new + 7 unchanged - 0 fixed = 36 total (was 7)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 3s	The patch has no ill-formed XML file.
+0 🆗	refguide	5m 2s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	10m 59s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	10m 53s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 52s	The patch does not generate ASF License warnings.
		62m 57s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1814
Optional Tests	dupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 563604ed26d0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a7a0e1a`
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-general-check/output/branch-site/book.html
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-general-check/output/diff-checkstyle-root.txt
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count	137 (vs. ulimit of 12500)
modules	C: hbase-common hbase-hadoop-compat hbase-http . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-05T10:20:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 40s	master passed
+1 💚	compile	3m 3s	master passed
+1 💚	shadedjars	6m 26s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 15s	root in master failed.
-0 ⚠️	javadoc	0m 15s	hbase-common in master failed.
-0 ⚠️	javadoc	0m 17s	hbase-hadoop-compat in master failed.
-0 ⚠️	javadoc	0m 17s	hbase-http in master failed.
-0 ⚠️	patch	8m 2s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 28s	the patch passed
+1 💚	compile	3m 3s	the patch passed
+1 💚	javac	3m 3s	the patch passed
+1 💚	shadedjars	6m 21s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 15s	hbase-common in the patch failed.
-0 ⚠️	javadoc	0m 18s	hbase-hadoop-compat in the patch failed.
-0 ⚠️	javadoc	0m 16s	hbase-http in the patch failed.
-0 ⚠️	javadoc	0m 13s	root in the patch failed.
		_ Other Tests _
+1 💚	unit	240m 18s	root in the patch passed.
		274m 35s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1814
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b180c78c89f4 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a7a0e1a`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/testReport/
Max. process+thread count	4471 (vs. ulimit of 12500)
modules	C: hbase-common hbase-hadoop-compat hbase-http . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-05T11:16:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 37s	master passed
+1 💚	compile	2m 19s	master passed
+1 💚	shadedjars	5m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 52s	master passed
-0 ⚠️	patch	9m 1s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 21s	the patch passed
+1 💚	compile	2m 17s	the patch passed
+1 💚	javac	2m 17s	the patch passed
+1 💚	shadedjars	5m 29s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 49s	the patch passed
		_ Other Tests _
-1 ❌	unit	298m 31s	root in the patch failed.
		330m 49s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1814
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 86bf582967f0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a7a0e1a`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/testReport/
Max. process+thread count	4225 (vs. ulimit of 12500)
modules	C: hbase-common hbase-hadoop-compat hbase-http . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-13T14:47:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	8m 16s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 25s	master passed
+1 💚	checkstyle	2m 22s	master passed
+0 🆗	refguide	6m 18s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	12m 6s	master passed
-0 ⚠️	patch	1m 13s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 56s	the patch passed
-0 ⚠️	checkstyle	1m 55s	root: The patch generated 29 new + 7 unchanged - 0 fixed = 36 total (was 7)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+0 🆗	refguide	5m 5s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	11m 37s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	11m 36s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 47s	The patch does not generate ASF License warnings.
		77m 19s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1814
Optional Tests	dupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 3e41f925b1ea 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3bd5421`
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/1/artifact/yetus-general-check/output/branch-site/book.html
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/1/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count	137 (vs. ulimit of 12500)
modules	C: hbase-common hbase-hadoop-compat hbase-http . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-14T06:54:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 36s	master passed
+1 💚	checkstyle	1m 56s	master passed
+0 🆗	refguide	4m 45s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	10m 26s	master passed
-0 ⚠️	patch	1m 9s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 23s	the patch passed
-0 ⚠️	checkstyle	1m 54s	root: The patch generated 29 new + 7 unchanged - 0 fixed = 36 total (was 7)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+0 🆗	refguide	4m 58s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	11m 17s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	10m 55s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 54s	The patch does not generate ASF License warnings.
		63m 38s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1814
Optional Tests	dupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 3652964bfb7e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3bd5421`
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-general-check/output/branch-site/book.html
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt
refguide	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count	138 (vs. ulimit of 12500)
modules	C: hbase-common hbase-hadoop-compat hbase-http . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-14T10:17:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 43s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 59s	master passed
+1 💚	compile	3m 12s	master passed
+1 💚	shadedjars	6m 46s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 18s	root in master failed.
-0 ⚠️	javadoc	0m 17s	hbase-common in master failed.
-0 ⚠️	javadoc	0m 20s	hbase-hadoop-compat in master failed.
-0 ⚠️	javadoc	0m 16s	hbase-http in master failed.
-0 ⚠️	patch	8m 31s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 49s	the patch passed
+1 💚	compile	3m 14s	the patch passed
+1 💚	javac	3m 14s	the patch passed
+1 💚	shadedjars	6m 38s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 21s	hbase-common in the patch failed.
-0 ⚠️	javadoc	0m 22s	hbase-hadoop-compat in the patch failed.
-0 ⚠️	javadoc	0m 21s	hbase-http in the patch failed.
-0 ⚠️	javadoc	0m 15s	root in the patch failed.
		_ Other Tests _
-1 ❌	unit	229m 26s	root in the patch failed.
		266m 20s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1814
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1c6f0ebacc85 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3bd5421`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/testReport/
Max. process+thread count	3216 (vs. ulimit of 12500)
modules	C: hbase-common hbase-hadoop-compat hbase-http . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-14T12:25:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 43s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 17s	master passed
+1 💚	compile	2m 41s	master passed
+1 💚	shadedjars	6m 10s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 8s	master passed
-0 ⚠️	patch	9m 51s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 1s	the patch passed
+1 💚	compile	2m 39s	the patch passed
+1 💚	javac	2m 39s	the patch passed
+1 💚	shadedjars	6m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 10s	the patch passed
		_ Other Tests _
-1 ❌	unit	357m 47s	root in the patch failed.
		394m 50s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1814
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a35c5e4bbecb 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3bd5421`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/testReport/
Max. process+thread count	2979 (vs. ulimit of 12500)
modules	C: hbase-common hbase-hadoop-compat hbase-http . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

HBASE-20904 Prometheus /metrics http endpoint for monitoring

2213ae2

This comment has been minimized.

Sign in to view

Fixed the classrule build error

0ea94ff

This comment has been minimized.

Sign in to view

saintstack reviewed May 31, 2020

View reviewed changes

mmpataki requested a review from saintstack May 31, 2020 05:29

mmpataki force-pushed the HBASE-20904 branch from 68e33c6 to 1d83e66 Compare May 31, 2020 05:49

This comment has been minimized.

Sign in to view

Added a configuration to enable/disable the servlets

373ea6d

mmpataki force-pushed the HBASE-20904 branch from 1d83e66 to 373ea6d Compare May 31, 2020 09:40

This comment has been minimized.

Sign in to view

mmpataki marked this pull request as draft May 31, 2020 10:49

This comment has been minimized.

Sign in to view

Removed the dead code from the renderMetrics method

bbc0744

This comment has been minimized.

Sign in to view

Added category for the TestPrometheusUtils

dfb114c

mmpataki commented Jun 23, 2020

View reviewed changes

Using java/concurrent/locks for synchronization

5326368

removed some dead, unnecessary code

8a198b4

Apache9 closed this Aug 24, 2022

Conversation

mmpataki commented May 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

busbey commented May 30, 2020

Uh oh!

mmpataki commented May 30, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mmpataki commented May 30, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

saintstack commented May 31, 2020

Uh oh!

saintstack left a comment

Choose a reason for hiding this comment

Uh oh!

mmpataki commented May 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmpataki commented May 31, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mmpataki commented May 31, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Jun 23, 2020

Uh oh!

mmpataki Jun 23, 2020

Choose a reason for hiding this comment

Uh oh!

mmpataki commented Jun 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Jun 23, 2020

Uh oh!

Apache-HBase commented Jun 23, 2020

Uh oh!

busbey commented Jun 25, 2020

Uh oh!

busbey commented Jun 25, 2020

Uh oh!

mmpataki commented Jun 25, 2020

Uh oh!

mmpataki commented Jun 28, 2020

Uh oh!

Apache-HBase commented Jul 5, 2020

Uh oh!

Apache-HBase commented Jul 5, 2020

Uh oh!

Apache-HBase commented Jul 5, 2020

Uh oh!

Apache-HBase commented Jul 13, 2020

Uh oh!

Apache-HBase commented Jul 14, 2020

Uh oh!

Apache-HBase commented Jul 14, 2020

Uh oh!

Apache-HBase commented Jul 14, 2020

Uh oh!

mmpataki commented May 30, 2020 •

edited

Loading

mmpataki commented May 31, 2020 •

edited

Loading

mmpataki commented Jun 23, 2020 •

edited

Loading