HBASE-24005 Document maven invocation with JDK11#1871
Merged
ndimiduk merged 1 commit intoapache:masterfrom Jun 9, 2020
Merged
Conversation
Member
Author
|
Please take a look. @joshelser @busbey @saintstack @HorizonNet @virajjasani @apurtell @infraio @Apache9 |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
HorizonNet
approved these changes
Jun 8, 2020
Contributor
HorizonNet
left a comment
HorizonNet
left a comment
There was a problem hiding this comment.
LGTM. Left a minor NIT and a (non-blocking) question.
virajjasani
approved these changes
Jun 8, 2020
ndimiduk
force-pushed
the
24005-document-jdk11-hadoop3
branch
from
e1123ee to
e9c8f0f
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ndimiduk
force-pushed
the
24005-document-jdk11-hadoop3
branch
from
3a0eebe to
7e695bc
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
busbey
reviewed
Jun 8, 2020
| ---- | ||
|
|
||
| To change the major release line of Hadoop we build against, add a hadoop.profile property when you invoke +mvn+: | ||
| .Example 2, Building HBase 2.3 against Hadoop 3.3.0-SNAPSHOT |
Contributor
There was a problem hiding this comment.
nit: we shouldn't be telling folks to build against non-released versions of Apache Hadoop I think?
Contributor
There was a problem hiding this comment.
this is where it's problematic that our ref guide is both the resource for downstream users of HBase and the development community of HBase. Can we make this "build against a different major release line of hadoop" use a released version? and then belwo when we talk about development versions include a note that the instructions are for folks subscribed to dev@hbase working on development of the project?
Member
Author
There was a problem hiding this comment.
Is it that much of a problem? I could simply drop the SNAPSHOT bits and update the language to sound like that version was already released. It'll eventually be accurate...
I could also edit the example context slightly, saying "this is how a developer of Hadoop might verify the compatibility of a recent Hadoop build against a recent hbase build."
Contributor
There was a problem hiding this comment.
I like that last proposed edit.
How much of a problem telling folks to use unreleased artifacts is depends on the winds of ASF policy vs spirit stuff. So I'd rather avoid getting near the morass
Member
Author
There was a problem hiding this comment.
@busbey updated the language around the SNAPSHOT dependency, let me know if this satisfies.
|
🎊 +1 overall
This message was automatically generated. |
HorizonNet
approved these changes
Jun 9, 2020
Contributor
HorizonNet
left a comment
HorizonNet
left a comment
There was a problem hiding this comment.
LGTM, especially the examples are really helpful for understanding.
ndimiduk
force-pushed
the
24005-document-jdk11-hadoop3
branch
from
7e695bc to
8543ac1
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
busbey
approved these changes
Jun 9, 2020
|
🎊 +1 overall
This message was automatically generated. |
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Sean Busbey <busbey@apache.org>
ndimiduk
force-pushed
the
24005-document-jdk11-hadoop3
branch
from
8543ac1 to
e3d262f
Compare
Member
Author
|
Thanks for the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to HBASE-23997, #1844.