HBASE-24552 Replica region needs to check if primary region directory… #1924

huaxiangsun · 2020-06-18T22:25:45Z

… exists at file system in TransitRegionStateProcedure

Apache-HBase · 2020-06-18T23:07:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 22s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 7s	master passed
+1 💚	checkstyle	1m 16s	master passed
+1 💚	spotbugs	2m 8s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 45s	the patch passed
+1 💚	checkstyle	1m 11s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 29s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 13s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		36m 25s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1924
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux c2b06c1a2dc5 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `537a3ca`
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-19T01:11:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 44s	master passed
+1 💚	compile	0m 55s	master passed
+1 💚	shadedjars	5m 36s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 29s	the patch passed
+1 💚	compile	0m 54s	the patch passed
+1 💚	javac	0m 54s	the patch passed
+1 💚	shadedjars	5m 35s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	137m 15s	hbase-server in the patch passed.
		161m 23s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1924
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fc3c05c77919 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `537a3ca`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/1/testReport/
Max. process+thread count	4577 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-19T02:40:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 11s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 53s	master passed
+1 💚	compile	1m 26s	master passed
+1 💚	shadedjars	7m 52s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 53s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 32s	the patch passed
+1 💚	compile	1m 21s	the patch passed
+1 💚	javac	1m 21s	the patch passed
+1 💚	shadedjars	7m 29s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 46s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	214m 32s	hbase-server in the patch passed.
		249m 58s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1924
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a50390715338 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `537a3ca`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/1/testReport/
Max. process+thread count	3010 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack

Looks good to me as a defence. File follow-on to fix read replicas?

...ver/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java

… exists at file system in TransitRegionStateProcedure

Apache-HBase · 2020-06-22T20:57:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 7s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 22s	master passed
+1 💚	checkstyle	1m 22s	master passed
+1 💚	spotbugs	2m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 16s	the patch passed
+1 💚	checkstyle	1m 36s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 54s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 46s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		41m 36s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1924
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 249e7065ea54 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5a79a1c`
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-22T22:48:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 42s	master passed
+1 💚	compile	1m 12s	master passed
+1 💚	shadedjars	5m 47s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 43s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 5s	the patch passed
+1 💚	compile	1m 8s	the patch passed
+1 💚	javac	1m 8s	the patch passed
+1 💚	shadedjars	5m 47s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 41s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	125m 52s	hbase-server in the patch passed.
		152m 37s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1924
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux aa03a70738c6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5a79a1c`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/2/testReport/
Max. process+thread count	4536 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-22T23:10:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 50s	master passed
+1 💚	compile	1m 12s	master passed
+1 💚	shadedjars	7m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 42s	the patch passed
+1 💚	compile	1m 11s	the patch passed
+1 💚	javac	1m 11s	the patch passed
+1 💚	shadedjars	7m 24s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	the patch passed
		_ Other Tests _
+1 💚	unit	143m 25s	hbase-server in the patch passed.
		175m 4s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1924
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d7cdf0951aad 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5a79a1c`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/2/testReport/
Max. process+thread count	3884 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1924/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

huaxiangsun · 2020-06-23T16:41:09Z

@saintstack, does the latest change look good to you?

… exists at file system in TransitRegionStateProcedure (apache#1924) Signed-off-by: stack <stack@apache.org>

… exists at file system in TransitRegionStateProcedure (#1924) (#1972) Signed-off-by: stack <stack@apache.org>

… exists at file system in TransitRegionStateProcedure (#1924) (#1971) Signed-off-by: stack <stack@apache.org>

… exists at file system in TransitRegionStateProcedure (apache#1924) (apache#1971) Signed-off-by: stack <stack@apache.org>

saintstack approved these changes Jun 22, 2020

View reviewed changes

...ver/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java Outdated Show resolved Hide resolved

...ver/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java Show resolved Hide resolved

HBASE-24552 Replica region needs to check if primary region directory…

1cabf82

… exists at file system in TransitRegionStateProcedure

huaxiangsun force-pushed the master.HBASE-24552 branch from 3650719 to 1cabf82 Compare June 22, 2020 20:06

huaxiangsun merged commit 82fad5d into apache:master Jun 24, 2020

huaxiangsun added a commit to huaxiangsun/hbase that referenced this pull request Jun 25, 2020

HBASE-24552 Replica region needs to check if primary region directory…

4500be3

… exists at file system in TransitRegionStateProcedure (apache#1924) Signed-off-by: stack <stack@apache.org>

huaxiangsun added a commit to huaxiangsun/hbase that referenced this pull request Jun 25, 2020

HBASE-24552 Replica region needs to check if primary region directory…

3a7d35b

… exists at file system in TransitRegionStateProcedure (apache#1924) Signed-off-by: stack <stack@apache.org>

This was referenced Jun 25, 2020

Backport: HBASE-24552 Replica region needs to check if primary region directory… #1971

Merged

Backport: HBASE-24552 Replica region needs to check if primary region directory… #1972

Merged

huaxiangsun added a commit that referenced this pull request Jun 26, 2020

HBASE-24552 Replica region needs to check if primary region directory…

809a623

… exists at file system in TransitRegionStateProcedure (#1924) (#1972) Signed-off-by: stack <stack@apache.org>

huaxiangsun added a commit that referenced this pull request Jun 26, 2020

HBASE-24552 Replica region needs to check if primary region directory…

2c201cc

… exists at file system in TransitRegionStateProcedure (#1924) (#1971) Signed-off-by: stack <stack@apache.org>

clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020

HBASE-24552 Replica region needs to check if primary region directory…

62e11dc

… exists at file system in TransitRegionStateProcedure (apache#1924) (apache#1971) Signed-off-by: stack <stack@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-24552 Replica region needs to check if primary region directory… #1924

HBASE-24552 Replica region needs to check if primary region directory… #1924

Uh oh!

huaxiangsun commented Jun 18, 2020

Uh oh!

Apache-HBase commented Jun 18, 2020

Uh oh!

Apache-HBase commented Jun 19, 2020

Uh oh!

Apache-HBase commented Jun 19, 2020

Uh oh!

saintstack left a comment

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Jun 22, 2020

Uh oh!

Apache-HBase commented Jun 22, 2020

Uh oh!

Apache-HBase commented Jun 22, 2020

Uh oh!

huaxiangsun commented Jun 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HBASE-24552 Replica region needs to check if primary region directory… #1924

HBASE-24552 Replica region needs to check if primary region directory… #1924

Uh oh!

Conversation

huaxiangsun commented Jun 18, 2020

Uh oh!

Apache-HBase commented Jun 18, 2020

Uh oh!

Apache-HBase commented Jun 19, 2020

Uh oh!

Apache-HBase commented Jun 19, 2020

Uh oh!

saintstack left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Jun 22, 2020

Uh oh!

Apache-HBase commented Jun 22, 2020

Uh oh!

Apache-HBase commented Jun 22, 2020

Uh oh!

huaxiangsun commented Jun 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants