HBASE-24611 : Bring back old constructor of SnapshotDescription as deprecated by virajjasani · Pull Request #1944 · apache/hbase

virajjasani · 2020-06-21T18:43:19Z

No description provided.

…precated

Apache-HBase · 2020-06-21T19:13:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 51s	master passed
+1 💚	compile	0m 25s	master passed
+1 💚	shadedjars	5m 34s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 31s	the patch passed
+1 💚	compile	0m 26s	the patch passed
+1 💚	javac	0m 26s	the patch passed
+1 💚	shadedjars	5m 39s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 23s	hbase-client generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
		_ Other Tests _
+1 💚	unit	1m 5s	hbase-client in the patch passed.
		23m 0s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1944
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1c8a1fe4cfbe 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8f1353b`
Default Java	1.8.0_232
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/1/testReport/
Max. process+thread count	341 (vs. ulimit of 12500)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-21T19:15:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 28s	master passed
+1 💚	compile	0m 30s	master passed
+1 💚	shadedjars	5m 47s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 28s	hbase-client in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 11s	the patch passed
+1 💚	compile	0m 29s	the patch passed
+1 💚	javac	0m 29s	the patch passed
+1 💚	shadedjars	5m 56s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 26s	hbase-client in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 9s	hbase-client in the patch passed.
		25m 9s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1944
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux acfaf851794f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8f1353b`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/1/testReport/
Max. process+thread count	289 (vs. ulimit of 12500)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-21T19:22:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 5s	master passed
+1 💚	checkstyle	0m 32s	master passed
+1 💚	spotbugs	1m 4s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 46s	the patch passed
-0 ⚠️	checkstyle	0m 27s	hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 23s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	1m 13s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		32m 29s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1944
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 64c4980f221a 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8f1353b`
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache9

Please fix the javadoc issue before committing.

virajjasani · 2020-06-22T06:23:26Z

Please fix the javadoc issue before committing.

Sure @Apache9 , updated the javadoc. Thank you.

…precated (#1944) Signed-off-by: Duo Zhang <zhangduo@apache.org>

Apache-HBase · 2020-06-22T06:53:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 48s	master passed
+1 💚	compile	0m 25s	master passed
+1 💚	shadedjars	5m 37s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 24s	the patch passed
+1 💚	compile	0m 25s	the patch passed
+1 💚	javac	0m 25s	the patch passed
+1 💚	shadedjars	5m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 4s	hbase-client in the patch passed.
		22m 52s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1944
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2f479c043bf6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8f1353b`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/2/testReport/
Max. process+thread count	340 (vs. ulimit of 12500)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-22T06:58:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 48s	master passed
+1 💚	compile	0m 30s	master passed
+1 💚	shadedjars	6m 23s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 26s	hbase-client in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 31s	the patch passed
+1 💚	compile	0m 29s	the patch passed
+1 💚	javac	0m 29s	the patch passed
+1 💚	shadedjars	6m 24s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 24s	hbase-client in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 19s	hbase-client in the patch passed.
		27m 31s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1944
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a89acac8a51e 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8f1353b`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/2/testReport/
Max. process+thread count	214 (vs. ulimit of 12500)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-22T07:06:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 50s	master passed
+1 💚	checkstyle	0m 29s	master passed
+1 💚	spotbugs	1m 1s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 41s	the patch passed
+1 💚	checkstyle	0m 26s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	15m 5s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	1m 25s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		35m 54s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1944
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 12368661ec70 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8f1353b`
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1944/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

ndimiduk

+1, thank you!

…precated (apache#1944) Signed-off-by: Duo Zhang <zhangduo@apache.org>

HBASE-24611 : Bring back old constructor of SnapshotDescription as de…

4ebf1be

…precated

virajjasani requested review from Apache9, apurtell, ndimiduk and wchevreuil June 21, 2020 18:43

Apache9 approved these changes Jun 22, 2020

View reviewed changes

Updating javadoc with proper link

419d13a

virajjasani merged commit 2b5ea44 into apache:master Jun 22, 2020

virajjasani added a commit that referenced this pull request Jun 22, 2020

HBASE-24611 : Bring back old constructor of SnapshotDescription as de…

6725258

…precated (#1944) Signed-off-by: Duo Zhang <zhangduo@apache.org>

virajjasani added a commit that referenced this pull request Jun 22, 2020

HBASE-24611 : Bring back old constructor of SnapshotDescription as de…

4771c2d

…precated (#1944) Signed-off-by: Duo Zhang <zhangduo@apache.org>

ndimiduk reviewed Jun 22, 2020

View reviewed changes

clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020

HBASE-24611 : Bring back old constructor of SnapshotDescription as de…

5609c84

…precated (apache#1944) Signed-off-by: Duo Zhang <zhangduo@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-24611 : Bring back old constructor of SnapshotDescription as deprecated#1944

HBASE-24611 : Bring back old constructor of SnapshotDescription as deprecated#1944
virajjasani merged 2 commits intoapache:masterfrom
virajjasani:HBASE-24611-master

virajjasani commented Jun 21, 2020

Uh oh!

Apache-HBase commented Jun 21, 2020

Uh oh!

Apache-HBase commented Jun 21, 2020

Uh oh!

Apache-HBase commented Jun 21, 2020

Uh oh!

Apache9 left a comment

Uh oh!

virajjasani commented Jun 22, 2020

Uh oh!

Apache-HBase commented Jun 22, 2020

Uh oh!

Apache-HBase commented Jun 22, 2020

Uh oh!

Apache-HBase commented Jun 22, 2020

Uh oh!

ndimiduk left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

virajjasani commented Jun 21, 2020

Uh oh!

Apache-HBase commented Jun 21, 2020

Uh oh!

Apache-HBase commented Jun 21, 2020

Uh oh!

Apache-HBase commented Jun 21, 2020

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

virajjasani commented Jun 22, 2020

Uh oh!

Apache-HBase commented Jun 22, 2020

Uh oh!

Apache-HBase commented Jun 22, 2020

Uh oh!

Apache-HBase commented Jun 22, 2020

Uh oh!

ndimiduk left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants